From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from verein.lst.de ([213.95.11.211]:51658 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1731733AbeGQOy7 (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Tue, 17 Jul 2018 10:54:59 -0400
Date: Tue, 17 Jul 2018 16:24:37 +0200
From: Christoph Hellwig <hch@lst.de>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: Christoph Hellwig <hch@lst.de>, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Mike Rapoport <rppt@linux.vnet.ibm.com>,
        Jason Baron <jbaron@akamai.com>, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: waitqueue lockdep annotation V3
Message-ID: <20180717142437.GA20286@lst.de>
References: <20171214152344.6880-1-hch@lst.de> <20180712191753.fvk2qersdvhcoqzp@linux-r8p5>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180712191753.fvk2qersdvhcoqzp@linux-r8p5>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, Jul 12, 2018 at 12:17:53PM -0700, Davidlohr Bueso wrote:
> On Thu, 14 Dec 2017, Christoph Hellwig wrote:
>
>> Hi all,
>>
>> this series adds a strategic lockdep_assert_held to __wake_up_common
>> to ensure callers really do hold the wait_queue_head lock when calling
>> the unlocked wake_up variants.  It turns out epoll did not do this
>> for a fairly common path (hit all the time by systemd during bootup),
>> so the second patch fixed this instance as well.
>
> I ran into these changes because of patch 1 getting rid of ep->lock. Is
> there any reason why this series was never picked up?

I'd love to see this merged, but I never heard back about it.