From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:50184 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388467AbeG0U4y (ORCPT ); Fri, 27 Jul 2018 16:56:54 -0400 Date: Fri, 27 Jul 2018 15:33:33 -0400 From: Mike Snitzer To: Huaisheng Ye Cc: linux-nvdimm@lists.01.org, dan.j.williams@intel.com, axboe@kernel.dk, linux-s390@vger.kernel.org, dave.jiang@intel.com, martin.petersen@oracle.com, vishal.l.verma@intel.com, chengnt@lenovo.com, linux-fsdevel@vger.kernel.org, heiko.carstens@de.ibm.com, linux-kernel@vger.kernel.org, willy@infradead.org, colyli@suse.de, bart.vanassche@wdc.com, dm-devel@redhat.com, viro@zeniv.linux.org.uk, gregkh@linuxfoundation.org, schwidefsky@de.ibm.com, jack@suse.cz, ross.zwisler@linux.intel.com, agk@redhat.com, Huaisheng Ye Subject: Re: [PATCH v2 5/6] md/dm-writecache: Don't request pointer dummy_addr when not required Message-ID: <20180727193333.GA23266@redhat.com> References: <20180725162849.8320-1-yehs2007@zoho.com> <20180725162849.8320-6-yehs2007@zoho.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180725162849.8320-6-yehs2007@zoho.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Jul 25 2018 at 12:28pm -0400, Huaisheng Ye wrote: > From: Huaisheng Ye > > Function persistent_memory_claim doesn't need to get local pointer > dummy_addr from direct_access. Using NULL instead of having to pass > in a useless local pointer that caller then just throw away. > > Suggested-by: Ross Zwisler > Signed-off-by: Huaisheng Ye Acked-by: Mike Snitzer