From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:32956 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725860AbeG3GsY (ORCPT ); Mon, 30 Jul 2018 02:48:24 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6U5Ds8Z002375 for ; Mon, 30 Jul 2018 01:15:12 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2khva08454-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 30 Jul 2018 01:15:12 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 30 Jul 2018 06:15:09 +0100 Date: Mon, 30 Jul 2018 07:14:58 +0200 From: Martin Schwidefsky To: Huaisheng HS1 Ye Cc: "linux-s390@vger.kernel.org" , "heiko.carstens@de.ibm.com" , "bart.vanassche@wdc.com" , "martin.petersen@oracle.com" , "axboe@kernel.dk" , "keescook@chromium.org" , "ross.zwisler@linux.intel.com" , "willy@infradead.org" , "vishal.l.verma@intel.com" , "dave.jiang@intel.com" , "viro@zeniv.linux.org.uk" , "gregkh@linuxfoundation.org" , "jack@suse.cz" , "agk@redhat.com" , "snitzer@redhat.com" , "dm-devel@redhat.com" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "NingTing Cheng" , "colyli@suse.de" , Huaisheng Ye , "linux-nvdimm@lists.01.org" , "dan.j.williams@intel.com" Subject: Re: [External] [PATCH v2 2/6] s390, dcssblk: kaddr and pfn can be NULL to ->direct_access() In-Reply-To: References: <20180725162849.8320-1-yehs2007@zoho.com> <20180725162849.8320-3-yehs2007@zoho.com> MIME-Version: 1.0 Message-Id: <20180730071458.42e3c5a1@mschwideX1> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, 28 Jul 2018 04:07:25 +0000 Huaisheng HS1 Ye wrote: > May I have your ack's for this patch? The whole series would be applied > to libnvdimm if it could get your approval. > And any suggestion is welcome. Sure, it is just two additional ifs. I did not think that this needed an ack, but here you go: Acked-by: Martin Schwidefsky > > Cheers, > Huaisheng Ye > > > From: Huaisheng Ye > > Sent: Thursday, July 26, 2018 12:29 AM > > > > From: Huaisheng Ye > > > > dcssblk_direct_access() needs to check the validity of pointers kaddr > > and pfn for NULL assignment. If anyone equals to NULL, it doesn't need > > to calculate the value. > > > > If either of them is equal to NULL, that is to say callers may > > have no need for kaddr or pfn, so this patch is prepared for allowing > > them to pass in NULL instead of having to pass in a pointer or local > > variable that they then just throw away. > > > > Signed-off-by: Huaisheng Ye > > --- > > drivers/s390/block/dcssblk.c | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/s390/block/dcssblk.c b/drivers/s390/block/dcssblk.c > > index ed60728..23e526c 100644 > > --- a/drivers/s390/block/dcssblk.c > > +++ b/drivers/s390/block/dcssblk.c > > @@ -922,9 +922,11 @@ static DEVICE_ATTR(save, S_IWUSR | S_IRUSR, dcssblk_save_show, > > unsigned long dev_sz; > > > > dev_sz = dev_info->end - dev_info->start + 1; > > - *kaddr = (void *) dev_info->start + offset; > > - *pfn = __pfn_to_pfn_t(PFN_DOWN(dev_info->start + offset), > > - PFN_DEV|PFN_SPECIAL); > > + if (kaddr) > > + *kaddr = (void *) dev_info->start + offset; > > + if (pfn) > > + *pfn = __pfn_to_pfn_t(PFN_DOWN(dev_info->start + offset), > > + PFN_DEV|PFN_SPECIAL); > > > > return (dev_sz - offset) / PAGE_SIZE; > > } > > -- > > 1.8.3.1 > -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.