From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.mailbox.org ([80.241.60.215]:54746 "EHLO mx2.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726861AbeG3VtH (ORCPT ); Mon, 30 Jul 2018 17:49:07 -0400 Date: Mon, 30 Jul 2018 22:12:24 +0200 From: Christian Brauner To: Christoph Hellwig Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, arve@android.com, tkjos@android.com, maco@android.com, rlove@google.com, ben@decadent.org.uk Subject: Re: [RFC PATCH 0/4] file: export functions for binder module Message-ID: <20180730201224.GA1081@mailbox.org> References: <20180730143710.14413-1-christian@brauner.io> <20180730163452.GE27761@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180730163452.GE27761@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jul 30, 2018 at 09:34:52AM -0700, Christoph Hellwig wrote: > On Mon, Jul 30, 2018 at 04:37:06PM +0200, Christian Brauner wrote: > > Hey, > > > > We currently plan on turning the Android binder and ashmem driver into a > > module. We have seen more and more requests by users to be able to use > > the binder and ashmem features without wanting to convince each distro > > to enable it by default in their kernel. Debian already started to carry > > patches for turning them into modules. > > Yikes. I really wish Debian would stick more to upstream rather than > picking random crap like this up. Thanks for the review, Christoph. Unfortunately the gist of the message got cut off: > I don't expect this patch to be mergeable but rather to kick-off a > discussion if we can either simply export them as they are or how we can > get supportable exports that allow access to struct files_struct. Maybe that wasn't obvious from the first message. Is there any way we can come up with a way to have versions of these functions that you would be fine with exporting? The point is that otherwise we would have to either duplicate the code or come up with something way more complex. If you have any pointer that would already help. Christian