From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv.linux.org.uk ([195.92.253.2]:47194 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725765AbeHBExl (ORCPT ); Thu, 2 Aug 2018 00:53:41 -0400 Date: Thu, 2 Aug 2018 04:04:43 +0100 From: Al Viro To: zhong jiang Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs/binfmt_elf: remove the same condition check Message-ID: <20180802030442.GW30522@ZenIV.linux.org.uk> References: <1533175228-17547-1-git-send-email-zhongjiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1533175228-17547-1-git-send-email-zhongjiang@huawei.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Aug 02, 2018 at 10:00:28AM +0800, zhong jiang wrote: > dump_align is used to double check in a expression. It is redundant. > so just remove one of them. What makes you think that it is redundant? > Signed-off-by: zhong jiang > --- > fs/binfmt_elf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c > index efae2fb..b6c5b02 100644 > --- a/fs/binfmt_elf.c > +++ b/fs/binfmt_elf.c > @@ -1439,7 +1439,7 @@ static int writenote(struct memelfnote *men, struct coredump_params *cprm) > > return dump_emit(cprm, &en, sizeof(en)) && > dump_emit(cprm, men->name, en.n_namesz) && dump_align(cprm, 4) && > - dump_emit(cprm, men->data, men->datasz) && dump_align(cprm, 4); > + dump_emit(cprm, men->data, men->datasz); > } > > static void fill_elf_header(struct elfhdr *elf, int segs, > -- > 1.7.12.4 >