From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from nautica.notk.org ([91.121.71.147]:35840 "EHLO nautica.notk.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727122AbeHBX5G (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Thu, 2 Aug 2018 19:57:06 -0400
Date: Fri, 3 Aug 2018 00:03:43 +0200
From: Dominique Martinet <asmadeus@codewreck.org>
To: Greg Kurz <groug@kaod.org>
Cc: v9fs-developer@lists.sourceforge.net,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Dominique Martinet <dominique.martinet@cea.fr>,
        Matthew Wilcox <willy@infradead.org>,
        Jun Piao <piaojun@huawei.com>
Subject: Re: [PATCH v2 1/2] net/9p: embed fcall in req to round down buffer
 allocs
Message-ID: <20180802220343.GB14773@nautica>
References: <1532943263-24378-1-git-send-email-asmadeus@codewreck.org>
 <1533177452-2165-1-git-send-email-asmadeus@codewreck.org>
 <20180802112301.6b581f1c@bahia.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20180802112301.6b581f1c@bahia.lan>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Greg Kurz wrote on Thu, Aug 02, 2018:
> > @@ -443,9 +444,9 @@ static int rdma_request(struct p9_client *client, struct p9_req_t *req)
> >  	 **/
> >  	if (unlikely(atomic_read(&rdma->excess_rc) > 0)) {
> >  		if ((atomic_sub_return(1, &rdma->excess_rc) >= 0)) {
> > -			/* Got one ! */
> > -			kfree(req->rc);
> > -			req->rc = NULL;
> > +			/* Got one! */
> > +			kfree(req->rc.sdata);
> 
> Shouldn't this be p9_fcall_fini(&req->rc) ?

Right, I failed at bookkeeping, I changed that in the next patch but it
should have been done now.
Will add p9_fcall_fini to headers/export in this patch instead of the
next

> The rest looks good, so, with that fixed, you can add:
> 
> Reviewed-by: Greg Kurz <groug@kaod.org>

Thanks!

-- 
Dominique