From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: Ross Zwisler <zwisler@kernel.org>, Jan Kara <jack@suse.cz>,
linux-nvdimm@lists.01.org, darrick.wong@oracle.com,
lczerner@redhat.com, linux-ext4 <linux-ext4@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH v4 0/2] ext4: fix DAX dma vs truncate/hole-punch
Date: Mon, 6 Aug 2018 17:49:43 +0200 [thread overview]
Message-ID: <20180806154943.GA17666@lst.de> (raw)
In-Reply-To: <20180806035550.GE7395@dastard>
> > > This allows the direct I/O path to do I/O and raise & lower page->_refcount
> > > while we're executing a truncate/hole punch. This leads to us trying to free
> > > a page with an elevated refcount.
>
> I don't see how this is possible in XFS - maybe I'm missing
> something, but "direct IO submission during truncate" is not
> something that should ever be happening in XFS, DAX or not.
The pages involved in a direct I/O are not that of the file that
the direct I/O read/write syscalls are called on, but those of the
memory regions the direct I/O read/write syscalls operate on.
Those pages could be file backed and undergo a truncate at the
same time.
next prev parent reply other threads:[~2018-08-06 17:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180710191031.17919-1-ross.zwisler@linux.intel.com>
[not found] ` <20180711081741.lmr44sp4cmt3f6um@quack2.suse.cz>
[not found] ` <20180725222839.GA28304@linux.intel.com>
2018-07-27 16:28 ` [PATCH v4 0/2] ext4: fix DAX dma vs truncate/hole-punch Ross Zwisler
2018-08-06 3:55 ` Dave Chinner
2018-08-06 15:49 ` Christoph Hellwig [this message]
2018-08-06 22:25 ` Dave Chinner
2018-08-07 8:45 ` Jan Kara
2018-09-10 22:18 ` Eric Sandeen
2018-09-11 15:14 ` Jan Kara
2018-09-11 15:20 ` Jan Kara
2018-09-11 17:28 ` Theodore Y. Ts'o
2018-09-11 18:21 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180806154943.GA17666@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).