Re: [PATCH] hfsplus: fix decomposition of Hangul characters

Hin-Tak Leung
2017-11-28T16:15:20Z

--------------------------------------------
On Tue, 28/11/17, Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com> wrote:

> The algorithm is very simple, the best way to
> understand it is just
> looking at the code. I
> don't know the first thing about Korean writing, so
> I don't think I should attempt to explain
> why the decomposition is done
> this way. If
> somebody else is interested in the details, they can
> follow
> the citation in the header comment of
> the decompose_hangul function.

Apologies for coming into this a bit late.

A couple of points:

1. Hangul canonical composition and decomposition is a separate topic from compositions of latin characters with accents. It is described in

http://www.unicode.org/reports/tr15/tr15-18.html#Hangul

among other sources.

2. I think the mount option is a bit of a red-herring. I think we should just do what Mac OS X does - I think in the tech note it says something about storing things always in the decomposed form or composed form. Ideally we should make the differing mount options no-ops. Mac OS X does not need extra mount options, we shouldn't either.