From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-qk1-f194.google.com ([209.85.222.194]:39371 "EHLO
        mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725914AbeIBIrh (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Sun, 2 Sep 2018 04:47:37 -0400
Received: by mail-qk1-f194.google.com with SMTP id b19-v6so3864420qkc.6
        for <linux-fsdevel@vger.kernel.org>; Sat, 01 Sep 2018 21:33:14 -0700 (PDT)
Date: Sun, 2 Sep 2018 01:33:09 -0300
From: Ernesto =?utf-8?Q?A=2E_Fern=C3=A1ndez?=
        <ernesto.mnd.fernandez@gmail.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
        linux-fsdevel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/6] hfsplus: prevent btree data loss on root split
Message-ID: <20180902043309.aa3hcxbe2wsboc2x@eaf>
References: <26d882184fc43043a810114258f45277752186c7.1535682461.git.ernesto.mnd.fernandez@gmail.com>
 <20180831053642.GA29605@infradead.org>
 <20180831145554.un5pb46m4l74hrvp@eaf>
 <20180901044926.GI1572@dastard>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20180901044926.GI1572@dastard>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sat, Sep 01, 2018 at 02:49:26PM +1000, Dave Chinner wrote:
> On Fri, Aug 31, 2018 at 11:55:54AM -0300, Ernesto A. Fernández wrote:
> > On Thu, Aug 30, 2018 at 10:36:42PM -0700, Christoph Hellwig wrote:
> > > On Fri, Aug 31, 2018 at 12:58:19AM -0300, Ernesto A. Fernández wrote:
> > > > Creating, renaming or deleting a file may cause catalog corruption and
> > > > data loss.  This bug is randomly triggered by xfstests generic/027, but
> > > > here is a faster reproducer:
> > > > 
> > > >   truncate -s 50M fs.iso
> > > >   mkfs.hfsplus fs.iso
> > > >   mount fs.iso /mnt
> > > >   i=100
> > > >   while [ $i -le 150 ]; do
> > > >     touch /mnt/$i &>/dev/null
> > > >     ((++i))
> > > >   done
> > > >   i=100
> > > >   while [ $i -le 150 ]; do
> > > >     mv /mnt/$i /mnt/$(perl -e "print $i x82") &>/dev/null
> > > >     ((++i))
> > > >   done
> > > >   umount /mnt
> > > >   fsck.hfsplus -n fs.iso
> > > 
> > > It would be good to wire up this short reproducer as well for xfstests.
> > 
> > Yes, that's my intention. The problem is that mkfs.hfsplus does not allow
> > setting the size of the filesystem for scratch_mkfs_sized(); you need a
> > workaround with the device mapper. I think I should submit that patch first
> > and see if there is a problem with it.
> 
> You don't need to do that. We use loop devices like this w/ mkfs_dev
> quite a lot in fstests. For example, generic/361 has pretty much the
> exact code pattern you need....

I see what you mean in this case, but I really want to run every test that
uses _scratch_mkfs_sized(); generic/027 in particular, since it's the one
that found these bugs for me.

> 
> Cheers,
> 
> Dave.
> 
> 
> -- 
> Dave Chinner
> david@fromorbit.com