From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:59068 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727021AbeIQTnK (ORCPT ); Mon, 17 Sep 2018 15:43:10 -0400 Date: Mon, 17 Sep 2018 07:15:28 -0700 From: Davidlohr Bueso To: Waiman Long Cc: Alexander Viro , Jan Kara , Jeff Layton , "J. Bruce Fields" , Tejun Heo , Christoph Lameter , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Andi Kleen , Dave Chinner , Boqun Feng Subject: Re: [PATCH v9 3/5] vfs: Use dlock list for superblock's inode list Message-ID: <20180917141528.GI3902@linux-r8p5> References: <1536780532-4092-1-git-send-email-longman@redhat.com> <1536780532-4092-4-git-send-email-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1536780532-4092-4-git-send-email-longman@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 12 Sep 2018, Waiman Long wrote: >@@ -927,8 +921,6 @@ struct inode *new_inode(struct super_block *sb) > { > struct inode *inode; > >- spin_lock_prefetch(&sb->s_inode_list_lock); I think we can get rid of the spin_lock_prefetch call altogether as this is the only user left afaict.