linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
	nixiaoming@huawei.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] New fanotify event info API
Date: Thu, 27 Sep 2018 15:39:24 +0200	[thread overview]
Message-ID: <20180927133924.GA8800@quack2.suse.cz> (raw)
In-Reply-To: <20180921182031.3184-1-amir73il@gmail.com>

On Fri 21-09-18 21:20:29, Amir Goldstein wrote:
> Jan,
> 
> Reposting my slightly modified cleanup patch along with the patch
> from nixiaoming that uses it to add a new fanotify_init() flag.
> 
> After a few review cycles with nixiaoming, per his request, I took
> his FAN_EVENT_INFO_TID patch to my tree, fixes a couple of issues
> including commit message wording and tested it.
> 
> For me, the new API seems very intuitive, not sure why thread id was
> not reported to begin with, but if you like more concrete use cases,
> you will need to ask them from nixiaoming.
> 
> Thanks,
> Amir.
> 
> Amir Goldstein (1):
>   fanotify: store fanotify_init() flags in group's fanotify_data
> 
> nixiaoming (1):
>   fanotify: support reporting thread id instead of process id

Thanks. Both patches look good to me and I've queued them up to my tree.

								Honza

> 
>  fs/notify/fanotify/fanotify.c      |  9 ++++++---
>  fs/notify/fanotify/fanotify.h      |  2 +-
>  fs/notify/fanotify/fanotify_user.c | 10 +++++-----
>  fs/notify/fdinfo.c                 | 24 +-----------------------
>  include/linux/fanotify.h           |  4 ++++
>  include/linux/fsnotify_backend.h   |  4 ++--
>  include/uapi/linux/fanotify.h      |  9 +++++++--
>  7 files changed, 26 insertions(+), 36 deletions(-)
> 
> -- 
> 2.17.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

  parent reply	other threads:[~2018-09-27 19:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-21 18:20 [PATCH v2 0/2] New fanotify event info API Amir Goldstein
2018-09-21 18:20 ` [PATCH v2 1/2] fanotify: store fanotify_init() flags in group's fanotify_data Amir Goldstein
2018-09-21 18:20 ` [PATCH v2 2/2] fanotify: support reporting thread id instead of process id Amir Goldstein
2018-09-27 13:39 ` Jan Kara [this message]
2018-09-27 19:32   ` [PATCH v2 0/2] New fanotify event info API Amir Goldstein
2018-10-02  9:30     ` Jan Kara
2018-10-02 11:56       ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180927133924.GA8800@quack2.suse.cz \
    --to=jack@suse.cz \
    --cc=amir73il@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=nixiaoming@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).