From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f68.google.com ([209.85.128.68]:39340 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725925AbeJHOe4 (ORCPT ); Mon, 8 Oct 2018 10:34:56 -0400 Received: by mail-wm1-f68.google.com with SMTP id y144-v6so2691168wmd.4 for ; Mon, 08 Oct 2018 00:24:37 -0700 (PDT) Date: Mon, 8 Oct 2018 09:24:33 +0200 From: Carlos Maiolino To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, okozina@redhat.com Subject: Re: [RFC PATCH] iomap: Enable alignment check for iomap DIO in holes Message-ID: <20181008072433.ld5kxo4yutfb5tpk@odin.usersys.redhat.com> References: <20181005130316.4869-1-cmaiolino@redhat.com> <20181006095951.GA6047@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181006095951.GA6047@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, Oct 06, 2018 at 11:59:51AM +0200, Christoph Hellwig wrote: > On Fri, Oct 05, 2018 at 03:03:16PM +0200, Carlos Maiolino wrote: > > Commit 09230435dffdb13de507e5e40b524b0069fc5c7b refactor iomap_dio_actor > > into two different helpers for bio based IO and hole IO, although, the > > latter doesn't check for IO alignment anymore. > > > > Move the DIO alignment check up into the caller, so all iomap DIO has > > alignment checked. > > Why? The only reason to check alignmnet for actual I/O is because we > have to. There is no requirement to align holes. > > > Christoph, I tagged this patch as RFC, because I couldn't really identify if you > > intentionally dropped the alignment check for holes and inline actors, if you > > didn't drop the alignment check intentionally, please consider it as a normal > > patch. > > The primary intent was to simplify the code and not enforce alignment > for inline data support. Ok, thanks, so please disregard this patch. Cheers. -- Carlos