From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-f195.google.com ([209.85.222.195]:36504 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726054AbeJLDJI (ORCPT ); Thu, 11 Oct 2018 23:09:08 -0400 Received: by mail-qk1-f195.google.com with SMTP id a85-v6so6248002qkg.3 for ; Thu, 11 Oct 2018 12:40:25 -0700 (PDT) Date: Thu, 11 Oct 2018 16:40:20 -0300 From: Ernesto =?utf-8?Q?A=2E_Fern=C3=A1ndez?= To: Viacheslav Dubeyko Cc: linux-fsdevel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH 1/2] hfsplus: fix return value of hfsplus_get_block() Message-ID: <20181011194020.pwowja3onmqall4c@eaf> References: <2cd1301404ec7cf1e39c8f11a01a4302f1460ad6.1539195310.git.ernesto.mnd.fernandez@gmail.com> <1539281136.3094.1.camel@slavad-ubuntu-14.04> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1539281136.3094.1.camel@slavad-ubuntu-14.04> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Oct 11, 2018 at 11:05:36AM -0700, Viacheslav Dubeyko wrote: > On Wed, 2018-10-10 at 15:23 -0300, Ernesto A. Fernández wrote: > > Direct writes to empty inodes fail with EIO. The generic direct-io code > > is in part to blame (a patch has been submitted as "direct-io: allow > > direct writes to empty inodes"), but hfsplus is worse affected than the > > other filesystems because the fallback to buffered I/O doesn't happen. > > > > Could you please share more detailed explanation of the patch that > affects the HFS+ behavior? It's hard to follow what patch you mean. It was sent to linux-fsdevel: "direct-io: allow direct writes to empty inodes." > > Thanks, > Vyacheslav Dubeyko. > > > The problem is the return value of hfsplus_get_block() when called with > > !create. Change it to be more consistent with the other modules. > > > > Signed-off-by: Ernesto A. Fernández > > --- > > fs/hfsplus/extents.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/fs/hfsplus/extents.c b/fs/hfsplus/extents.c > > index 8a8893d522ef..a930ddd15681 100644 > > --- a/fs/hfsplus/extents.c > > +++ b/fs/hfsplus/extents.c > > @@ -237,7 +237,9 @@ int hfsplus_get_block(struct inode *inode, sector_t iblock, > > ablock = iblock >> sbi->fs_shift; > > > > if (iblock >= hip->fs_blocks) { > > - if (iblock > hip->fs_blocks || !create) > > + if (!create) > > + return 0; > > + if (iblock > hip->fs_blocks) > > return -EIO; > > if (ablock >= hip->alloc_blocks) { > > res = hfsplus_file_extend(inode, false); > >