From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-f194.google.com ([209.85.222.194]:39947 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725743AbeJMEe2 (ORCPT ); Sat, 13 Oct 2018 00:34:28 -0400 Received: by mail-qk1-f194.google.com with SMTP id a13-v6so8485648qkc.7 for ; Fri, 12 Oct 2018 14:00:09 -0700 (PDT) Date: Fri, 12 Oct 2018 18:00:03 -0300 From: Ernesto =?utf-8?Q?A=2E_Fern=C3=A1ndez?= To: Viacheslav Dubeyko Cc: linux-fsdevel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH 1/2] hfsplus: fix return value of hfsplus_get_block() Message-ID: <20181012210003.tmhdtfrogo7sz5dj@eaf> References: <2cd1301404ec7cf1e39c8f11a01a4302f1460ad6.1539195310.git.ernesto.mnd.fernandez@gmail.com> <1539281136.3094.1.camel@slavad-ubuntu-14.04> <20181011194020.pwowja3onmqall4c@eaf> <1539304715.3094.4.camel@slavad-ubuntu-14.04> <20181012004818.h44lfnwlkjd4l63j@eaf> <1539369786.3203.4.camel@slavad-ubuntu-14.04> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1539369786.3203.4.camel@slavad-ubuntu-14.04> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Oct 12, 2018 at 11:43:06AM -0700, Viacheslav Dubeyko wrote: > On Thu, 2018-10-11 at 21:48 -0300, Ernesto A. Fernández wrote: > > On Thu, Oct 11, 2018 at 05:38:35PM -0700, Viacheslav Dubeyko wrote: > > > On Thu, 2018-10-11 at 16:40 -0300, Ernesto A. Fernández wrote: > > > > On Thu, Oct 11, 2018 at 11:05:36AM -0700, Viacheslav Dubeyko wrote: > > > > > On Wed, 2018-10-10 at 15:23 -0300, Ernesto A. Fernández wrote: > > > > > > Direct writes to empty inodes fail with EIO. The generic direct-io code > > > > > > is in part to blame (a patch has been submitted as "direct-io: allow > > > > > > direct writes to empty inodes"), but hfsplus is worse affected than the > > > > > > other filesystems because the fallback to buffered I/O doesn't happen. > > > > > > > > > > > > > > > > Could you please share more detailed explanation of the patch that > > > > > affects the HFS+ behavior? It's hard to follow what patch you mean. > > > > > > > > It was sent to linux-fsdevel: "direct-io: allow direct writes to empty > > > > inodes." > > > > > > > > > > The git provides the commit ID and the annotation for every commit. It > > > will be great to see these details. Could you please share this > > > information? > > > > The patch hasn't been merged yet. > > > > I am not completely sure how to review the patch in such case. I believe > that the best strategy is to wait till the mentioned patch will be > merged and to resend this patch again. You can just ignore the direct-io patch if you find it confusing. It's a separate issue, and the hfs/hfsplus patches are actually easier to test by themselves. > Thanks, > Vyacheslav Dubeyko. > > >