From: Al Viro <viro@ZenIV.linux.org.uk>
To: Martin Brandenburg <martin@omnibond.com>
Cc: hubcap@omnibond.com, devel@lists.orangefs.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] orangefs: move new_inode call to namei
Date: Sat, 13 Oct 2018 04:24:37 +0100 [thread overview]
Message-ID: <20181013032437.GJ32577@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20181010022131.2954-1-martin@omnibond.com>
On Wed, Oct 10, 2018 at 02:21:31AM +0000, Martin Brandenburg wrote:
> Before, orangefs_new_inode could return NULL which was not handled.
> Instead allocate the inode before calling orangefs_new_inode where the
> failure can be handled.
Umm... Perhaps it would be easier to simply return ERR_PTR(-ENOMEM) in
the same situation?
prev parent reply other threads:[~2018-10-13 11:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 2:21 [PATCH] orangefs: move new_inode call to namei Martin Brandenburg
2018-10-13 3:24 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181013032437.GJ32577@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=devel@lists.orangefs.org \
--cc=hubcap@omnibond.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=martin@omnibond.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).