From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 14 Oct 2018 10:37:38 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: david@fromorbit.com, sandeen@redhat.com, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, Amir Goldstein , linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com Subject: Re: [PATCH 11/25] vfs: pass remap flags to generic_remap_file_range_prep Message-ID: <20181014173738.GA6400@infradead.org> References: <153938912912.8361.13446310416406388958.stgit@magnolia> <153938921860.8361.1983470639945895613.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <153938921860.8361.1983470639945895613.stgit@magnolia> Sender: owner-linux-mm@kvack.org List-ID: > + bool is_dedupe = (remap_flags & RFR_SAME_DATA); Btw, I think the code would be cleaner if we dropped this variable.