From: Matthew Bobrowski <mbobrowski@mbobrowski.org>
To: Jan Kara <jack@suse.cz>
Cc: amir73il@gmail.com, linux-api@vger.kernel.org, sgrubb@redhat.com,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v5 0/3] fanotify: introduce new event types FAN_OPEN_EXEC and FAN_OPEN_EXEC_PERM
Date: Thu, 18 Oct 2018 23:06:16 +1100 [thread overview]
Message-ID: <20181018120615.GB3620@workstation> (raw)
In-Reply-To: <20181018092821.GN23493@quack2.suse.cz>
On Thu, Oct 18, 2018 at 11:28:21AM +0200, Jan Kara wrote:
> On Wed 17-10-18 20:04:37, Matthew Bobrowski wrote:
> > Currently, the fanotify API does not provide a means for user space
> > applications to receive events when a file has been opened specifically
> > for execution. New event types FAN_OPEN_EXEC and FAN_OPEN_EXEC_PERM have
> > been introduced in order to provide users this capability.
>
> OK, so these patches look mostly ready (except for a small bits I've
> commented on patch 3).
OK, great. I can go ahead and perform the necessary updates. These are
minor though, so I'm not sure whether it's appropriate to actually send
through and entire new patch series that include these changes? To be fair
I'm not entirely sure how you're meant to really submit through these
minor updates based on previous reviews...
> How about the LTP test to actually test them? Once that exists, I can
> test the patches and merge them into my tree...
Yes, I'm working on them at the moment. I've got some time coming up this
weekend, so I hope to have them ready for you by then. It's a little
fiddly when it comes to incorporating the exec events into previous tests.
The way they're currently written doesn't really allow for them to be
somewhat extensible in my opinion. I've written a new test in a completely
separate test file, which is easy enough; however I think that these new
event types should most definitely be part of perviously written tests
i.e. fanotify03 for FAN_OPEN_EXEC_PERM. I've discussed this with Amir and
he also agrees.
--
Matthew Bobrowski <mbobrowski@mbobrowski.org>
next prev parent reply other threads:[~2018-10-18 20:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 9:04 [PATCH v5 0/3] fanotify: introduce new event types FAN_OPEN_EXEC and FAN_OPEN_EXEC_PERM Matthew Bobrowski
2018-10-17 9:05 ` [PATCH v5 1/3] fanotify: introduce new event type FAN_OPEN_EXEC Matthew Bobrowski
2018-10-17 9:05 ` [PATCH v5 2/3] fanotify: return only user requested event types in event mask Matthew Bobrowski
2018-10-17 9:05 ` [PATCH v5 3/3] fanotify: introduce new event type FAN_OPEN_EXEC_PERM Matthew Bobrowski
2018-10-18 9:26 ` Jan Kara
2018-10-18 11:55 ` Matthew Bobrowski
2018-10-18 9:28 ` [PATCH v5 0/3] fanotify: introduce new event types FAN_OPEN_EXEC and FAN_OPEN_EXEC_PERM Jan Kara
2018-10-18 12:06 ` Matthew Bobrowski [this message]
2018-10-18 12:48 ` Jan Kara
2018-10-24 4:52 ` Matthew Bobrowski
2018-10-18 10:07 ` Amir Goldstein
2018-10-18 12:12 ` Matthew Bobrowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181018120615.GB3620@workstation \
--to=mbobrowski@mbobrowski.org \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).