From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f66.google.com ([209.85.221.66]:35555 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727343AbeJRVMb (ORCPT ); Thu, 18 Oct 2018 17:12:31 -0400 Received: by mail-wr1-f66.google.com with SMTP id w5-v6so33624580wrt.2 for ; Thu, 18 Oct 2018 06:11:31 -0700 (PDT) From: Miklos Szeredi To: linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, David Howells , Michael Kerrisk , Andreas Dilger , Florian Weimer , Amir Goldstein , Mike Marshall , Martin Brandenburg Subject: [PATCH 1/3] orangefs: fix request_mask misuse Date: Thu, 18 Oct 2018 15:11:23 +0200 Message-Id: <20181018131125.6303-1-mszeredi@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Orangefs only handles STATX_BASIC_STATS in its getattr implementation, so mask off all other flags. Not doing so results in statx(2) forcing a refresh of cached attributes on any other requested flag (i.e. STATX_BTIME currently) due to the following test in orangefs_inode_getattr(): (request_mask & orangefs_inode->getattr_mask) == request_mask Also clean up gratuitous uses of STATX_ALL. Signed-off-by: Miklos Szeredi Cc: Mike Marshall Cc: Martin Brandenburg --- fs/orangefs/inode.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/orangefs/inode.c b/fs/orangefs/inode.c index 31932879b716..bd7f15a831dc 100644 --- a/fs/orangefs/inode.c +++ b/fs/orangefs/inode.c @@ -256,7 +256,8 @@ int orangefs_getattr(const struct path *path, struct kstat *stat, "orangefs_getattr: called on %pd\n", path->dentry); - ret = orangefs_inode_getattr(inode, 0, 0, request_mask); + ret = orangefs_inode_getattr(inode, 0, 0, + request_mask & STATX_BASIC_STATS); if (ret == 0) { generic_fillattr(inode, stat); @@ -408,7 +409,7 @@ struct inode *orangefs_iget(struct super_block *sb, if (!inode || !(inode->i_state & I_NEW)) return inode; - error = orangefs_inode_getattr(inode, 1, 1, STATX_ALL); + error = orangefs_inode_getattr(inode, 1, 1, STATX_BASIC_STATS); if (error) { iget_failed(inode); return ERR_PTR(error); @@ -453,7 +454,7 @@ struct inode *orangefs_new_inode(struct super_block *sb, struct inode *dir, orangefs_set_inode(inode, ref); inode->i_ino = hash; /* needed for stat etc */ - error = orangefs_inode_getattr(inode, 1, 1, STATX_ALL); + error = orangefs_inode_getattr(inode, 1, 1, STATX_BASIC_STATS); if (error) goto out_iput; -- 2.14.3