From: Matthew Wilcox <willy@infradead.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: olga.kornievskaia@gmail.com,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
fweimer@redhat.com, Steve French <smfrench@gmail.com>,
linux-api@vger.kernel.org
Subject: Re: [PATCH v1 02/11] VFS permit cross device vfs_copy_file_range
Date: Fri, 19 Oct 2018 10:44:46 -0700 [thread overview]
Message-ID: <20181019174446.GA28891@bombadil.infradead.org> (raw)
In-Reply-To: <CAOQ4uxg=Y784nrkYmqMpOKtQD9y9ZFk+SavXtuGp-KFTSf4rAQ@mail.gmail.com>
On Fri, Oct 19, 2018 at 07:14:23PM +0300, Amir Goldstein wrote:
> > On Fri, Oct 19, 2018 at 6:30 PM Olga Kornievskaia
> > <olga.kornievskaia@gmail.com> wrote:
> > > Allow copy_file_range to copy between different superblocks but only
> > > of the same file system types. This feature was of interest to CIFS
> > > as well as NFS.
>
> Sorry, you meant to allow cross sb copy from client, so you do want
> to change user facing behavior.
> For that you need to declare a flag to opt in for the new behavior
> and document it.
> Please keep linux-api CC-ed when posting the flag.
> Referencing a draft for man page is recommended.
Huh? We're allowed to make things work that used to fail. There's no
need to add a flag that the user must set.
next prev parent reply other threads:[~2018-10-20 1:51 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 15:30 [PATCH v1 01/11] fs: Don't copy beyond the end of the file Olga Kornievskaia
2018-10-19 15:30 ` [PATCH v1 02/11] VFS permit cross device vfs_copy_file_range Olga Kornievskaia
2018-10-19 15:54 ` Amir Goldstein
2018-10-19 16:14 ` Amir Goldstein
2018-10-19 17:44 ` Matthew Wilcox [this message]
2018-10-19 17:58 ` Amir Goldstein
2018-10-19 16:24 ` Olga Kornievskaia
2018-10-19 17:04 ` Olga Kornievskaia
2018-10-20 1:37 ` Steve French
2018-10-19 17:58 ` Matthew Wilcox
2018-10-19 18:47 ` Olga Kornievskaia
2018-10-19 19:06 ` Matthew Wilcox
2018-10-21 13:01 ` Jeff Layton
2018-10-22 18:39 ` Olga Kornievskaia
2018-10-21 14:10 ` Jeff Layton
2018-10-20 4:05 ` Al Viro
2018-10-20 8:54 ` Amir Goldstein
2018-10-22 18:45 ` Olga Kornievskaia
2018-10-22 19:06 ` Matthew Wilcox
2018-10-22 19:34 ` Olga Kornievskaia
2018-10-22 19:48 ` Amir Goldstein
2018-10-22 20:29 ` Matthew Wilcox
2018-10-22 23:39 ` Jeff Layton
2018-10-23 6:05 ` Amir Goldstein
2018-10-23 15:03 ` Olga Kornievskaia
2018-10-23 15:30 ` Olga Kornievskaia
2018-10-23 17:16 ` Olga Kornievskaia
2018-10-24 11:17 ` Jeff Layton
2018-10-24 19:59 ` Olga Kornievskaia
2018-10-25 4:58 ` Amir Goldstein
2018-10-25 15:58 ` Olga Kornievskaia
2018-10-25 16:00 ` Olga Kornievskaia
2018-10-25 16:57 ` Amir Goldstein
2018-10-23 15:39 ` Matthew Wilcox
2018-10-24 11:32 ` Amir Goldstein
[not found] <20181019152932.32462-1-olga.kornievskaia@gmail.com>
[not found] ` <20181019152932.32462-3-olga.kornievskaia@gmail.com>
2018-10-19 16:14 ` Trond Myklebust
2018-10-19 16:26 ` Olga Kornievskaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181019174446.GA28891@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=amir73il@gmail.com \
--cc=fweimer@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=olga.kornievskaia@gmail.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).