linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Goldwyn Rodrigues <rgoldwyn@suse.de>
To: ross.zwisler@linux.intel.com
Cc: linux-fsdevel@vger.kernel.org
Subject: [PATCH] Remove iomap parameter from dax_pmd_load_hole()
Date: Fri, 19 Oct 2018 14:28:06 -0500	[thread overview]
Message-ID: <20181019192806.nkr7ngk2nugbruie@merlin> (raw)

Trivial code cleanup.
This has been carried since the original patch
642261ac995e ("dax: add struct iomap based DAX PMD support")

dax_pmd_load_hole() does not use iomap. Remove the function parameter.

Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>

diff --git a/fs/dax.c b/fs/dax.c
index 0fb270f0a0ef..827acf713324 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -1505,8 +1505,7 @@ static vm_fault_t dax_iomap_pte_fault(struct vm_fault *vmf, pfn_t *pfnp,
 }
 
 #ifdef CONFIG_FS_DAX_PMD
-static vm_fault_t dax_pmd_load_hole(struct vm_fault *vmf, struct iomap *iomap,
-		void *entry)
+static vm_fault_t dax_pmd_load_hole(struct vm_fault *vmf, void *entry)
 {
 	struct address_space *mapping = vmf->vma->vm_file->f_mapping;
 	unsigned long pmd_addr = vmf->address & PMD_MASK;
@@ -1669,7 +1668,7 @@ static vm_fault_t dax_iomap_pmd_fault(struct vm_fault *vmf, pfn_t *pfnp,
 	case IOMAP_HOLE:
 		if (WARN_ON_ONCE(write))
 			break;
-		result = dax_pmd_load_hole(vmf, &iomap, entry);
+		result = dax_pmd_load_hole(vmf, entry);
 		break;
 	default:
 		WARN_ON_ONCE(1);

             reply	other threads:[~2018-10-20  3:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-19 19:28 Goldwyn Rodrigues [this message]
2018-10-25 11:47 ` [PATCH] Remove iomap parameter from dax_pmd_load_hole() Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181019192806.nkr7ngk2nugbruie@merlin \
    --to=rgoldwyn@suse.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=ross.zwisler@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).