* [PATCH] Remove iomap parameter from dax_pmd_load_hole()
@ 2018-10-19 19:28 Goldwyn Rodrigues
2018-10-25 11:47 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Goldwyn Rodrigues @ 2018-10-19 19:28 UTC (permalink / raw)
To: ross.zwisler; +Cc: linux-fsdevel
Trivial code cleanup.
This has been carried since the original patch
642261ac995e ("dax: add struct iomap based DAX PMD support")
dax_pmd_load_hole() does not use iomap. Remove the function parameter.
Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
diff --git a/fs/dax.c b/fs/dax.c
index 0fb270f0a0ef..827acf713324 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -1505,8 +1505,7 @@ static vm_fault_t dax_iomap_pte_fault(struct vm_fault *vmf, pfn_t *pfnp,
}
#ifdef CONFIG_FS_DAX_PMD
-static vm_fault_t dax_pmd_load_hole(struct vm_fault *vmf, struct iomap *iomap,
- void *entry)
+static vm_fault_t dax_pmd_load_hole(struct vm_fault *vmf, void *entry)
{
struct address_space *mapping = vmf->vma->vm_file->f_mapping;
unsigned long pmd_addr = vmf->address & PMD_MASK;
@@ -1669,7 +1668,7 @@ static vm_fault_t dax_iomap_pmd_fault(struct vm_fault *vmf, pfn_t *pfnp,
case IOMAP_HOLE:
if (WARN_ON_ONCE(write))
break;
- result = dax_pmd_load_hole(vmf, &iomap, entry);
+ result = dax_pmd_load_hole(vmf, entry);
break;
default:
WARN_ON_ONCE(1);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Remove iomap parameter from dax_pmd_load_hole()
2018-10-19 19:28 [PATCH] Remove iomap parameter from dax_pmd_load_hole() Goldwyn Rodrigues
@ 2018-10-25 11:47 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2018-10-25 11:47 UTC (permalink / raw)
To: Goldwyn Rodrigues; +Cc: Ross Zwisler, linux-fsdevel, Dan Williams
On Fri 19-10-18 14:28:06, Goldwyn Rodrigues wrote:
> Trivial code cleanup.
> This has been carried since the original patch
> 642261ac995e ("dax: add struct iomap based DAX PMD support")
>
> dax_pmd_load_hole() does not use iomap. Remove the function parameter.
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
Ross is no longer with Intel - replaced address. Also Dan merges DAX
patches like this - added to CC. Finally, feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
>
> diff --git a/fs/dax.c b/fs/dax.c
> index 0fb270f0a0ef..827acf713324 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -1505,8 +1505,7 @@ static vm_fault_t dax_iomap_pte_fault(struct vm_fault *vmf, pfn_t *pfnp,
> }
>
> #ifdef CONFIG_FS_DAX_PMD
> -static vm_fault_t dax_pmd_load_hole(struct vm_fault *vmf, struct iomap *iomap,
> - void *entry)
> +static vm_fault_t dax_pmd_load_hole(struct vm_fault *vmf, void *entry)
> {
> struct address_space *mapping = vmf->vma->vm_file->f_mapping;
> unsigned long pmd_addr = vmf->address & PMD_MASK;
> @@ -1669,7 +1668,7 @@ static vm_fault_t dax_iomap_pmd_fault(struct vm_fault *vmf, pfn_t *pfnp,
> case IOMAP_HOLE:
> if (WARN_ON_ONCE(write))
> break;
> - result = dax_pmd_load_hole(vmf, &iomap, entry);
> + result = dax_pmd_load_hole(vmf, entry);
> break;
> default:
> WARN_ON_ONCE(1);
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-25 20:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-19 19:28 [PATCH] Remove iomap parameter from dax_pmd_load_hole() Goldwyn Rodrigues
2018-10-25 11:47 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).