From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f195.google.com ([209.85.215.195]:46626 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726433AbeJXNSg (ORCPT ); Wed, 24 Oct 2018 09:18:36 -0400 Received: by mail-pg1-f195.google.com with SMTP id a5-v6so836619pgt.13 for ; Tue, 23 Oct 2018 21:52:10 -0700 (PDT) Date: Wed, 24 Oct 2018 15:52:03 +1100 From: Matthew Bobrowski To: Jan Kara Cc: amir73il@gmail.com, linux-api@vger.kernel.org, sgrubb@redhat.com, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v5 0/3] fanotify: introduce new event types FAN_OPEN_EXEC and FAN_OPEN_EXEC_PERM Message-ID: <20181024045201.GA1518@development.internal.lab> References: <20181018092821.GN23493@quack2.suse.cz> <20181018120615.GB3620@workstation> <20181018124836.GR23493@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181018124836.GR23493@quack2.suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi Jan, On Thu, Oct 18, 2018 at 02:48:36PM +0200, Jan Kara wrote: > On Thu 18-10-18 23:06:16, Matthew Bobrowski wrote: > > On Thu, Oct 18, 2018 at 11:28:21AM +0200, Jan Kara wrote: > > > On Wed 17-10-18 20:04:37, Matthew Bobrowski wrote: > > > > Currently, the fanotify API does not provide a means for user space > > > > applications to receive events when a file has been opened specifically > > > > for execution. New event types FAN_OPEN_EXEC and FAN_OPEN_EXEC_PERM have > > > > been introduced in order to provide users this capability. > > > > > > OK, so these patches look mostly ready (except for a small bits I've > > > commented on patch 3). > > > > OK, great. I can go ahead and perform the necessary updates. These are > > minor though, so I'm not sure whether it's appropriate to actually send > > through and entire new patch series that include these changes? To be fair > > I'm not entirely sure how you're meant to really submit through these > > minor updates based on previous reviews... > > I guess I can just make the changes when picking up patches. If you like, you may obtain a copy of patch 3 for this patch series from the link I've provided below. It contains the minor update around adding FS_OPEN_EXEC_PERM to ALL_FSNOTIFY_PERM_EVENTS. Saves you having to remember to do it when applying the patches to your tree. https://mbobrowski.org/patches/kernel/0003-fanotify.patch -- Matthew Bobrowski