From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com ([209.85.221.67]:42153 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726531AbeJXQso (ORCPT ); Wed, 24 Oct 2018 12:48:44 -0400 Received: by mail-wr1-f67.google.com with SMTP id y15-v6so140658wru.9 for ; Wed, 24 Oct 2018 01:21:37 -0700 (PDT) Date: Wed, 24 Oct 2018 09:21:34 +0100 From: Phillip Potter To: Amir Goldstein Cc: viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [RFC][PATCH v3 01/10] fs: common implementation of file type Message-ID: <20181024082134.GA14565@pathfinder> References: <20181023201953.GA15687@pathfinder> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Oct 24, 2018 at 09:16:20AM +0300, Amir Goldstein wrote: > On Tue, Oct 23, 2018 at 11:19 PM Phillip Potter wrote: > > > > Many file systems use a copy&paste implementation > > of dirent to on-disk file type conversions. > > > > Create a common implementation to be used by file systems > > with some useful conversion helpers to reduce open coded > > file type conversions in file system code. > > > > Original patch written by Amir Goldstein. > > Looks good. > I guess you used 'git apply' or just 'patch' > What you usually do when applying someone else mostly unchanged > patches is use 'git am -s -3' so you preserve the original author and > original commit message including the Signed-of-by line. > You can edit your patch by hand to change the From: line to change the > author and add > Signed-off-by: Amir Goldstein > (you sign below me as you changed the patch last) > Dear Amir, Yes, I applied each patch manually to my tree, fixed it up where needed, then after rebuilding and testing each one I committed it and regenerated each patch. Thank you very much for your advice, I will take it into account and make the necessary changes. In the meantime, do I add other tags in the order they are received also (such as Reviewed-by:) and am I safe to add these in when I re-send the patches with the changes you and others have suggested (or would that offend people that have offered the tags)? Regards, Phil