From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from imap.thunk.org ([74.207.234.97]:52602 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726267AbeJXVaQ (ORCPT ); Wed, 24 Oct 2018 17:30:16 -0400 Date: Wed, 24 Oct 2018 09:02:06 -0400 From: "Theodore Y. Ts'o" To: Phillip Potter Cc: viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, amir73il@gmail.com, linux-fsdevel@vger.kernel.org Subject: Re: [RFC][PATCH v3 01/10] fs: common implementation of file type Message-ID: <20181024130206.GC11606@thunk.org> References: <20181023201953.GA15687@pathfinder> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181023201953.GA15687@pathfinder> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Oct 23, 2018 at 09:19:53PM +0100, Phillip Potter wrote: > diff --git a/include/linux/file_type.h b/include/linux/file_type.h Shouldn't this be in include/uapi/linux/fs_types.h? One of things which must be made crystal clear is these definitions MUST NOT ever change. It would break the Userspace ABI, and would break file systems on-disk format. It might also be useful to be clear *why* we are making this change in the first place. Code refactorization is good from a code maintenance perspective (either to fix bugs, although this code is pretty trivial), or to make it easier to make changes in a single central place (which MUST NOT) happen, or to make the compiled code more compact. So some documentation of how much text is actually saved might be worthwhile. - Ted