From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f65.google.com ([209.85.221.65]:39125 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726267AbeJXV75 (ORCPT ); Wed, 24 Oct 2018 17:59:57 -0400 Received: by mail-wr1-f65.google.com with SMTP id r10-v6so4722296wrv.6 for ; Wed, 24 Oct 2018 06:31:48 -0700 (PDT) Date: Wed, 24 Oct 2018 14:31:45 +0100 From: Phillip Potter To: Boaz Harrosh Cc: amir73il@gmail.com, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org Subject: Re: [RFC][PATCH v2 05/10] exofs: use common file type conversion Message-ID: <20181024133145.GB23398@pathfinder> References: <20181023201959.GA15715@pathfinder> <11231c2a-0bb8-5c87-a65c-4fc7ff47f866@electrozaur.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11231c2a-0bb8-5c87-a65c-4fc7ff47f866@electrozaur.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Oct 24, 2018 at 02:56:58PM +0300, Boaz Harrosh wrote: > On 23/10/18 23:19, Phillip Potter wrote: > > Deduplicate the exofs file type conversion implementation. > > > > Original patch by Amir Goldstein. > > > > v2: > > - This version does not remove EXOFS_FT_x enum from fs/exofs/common.h, > > as these values are now used in compile-time checks added by > > Phillip Potter to make sure they remain the same as FT_x values > > > > v1: > > - Initial implementation > > > > Signed-off-by: Phillip Potter > > Yes thank you, totally > > ACK-by: Boaz Harrosh > Dear Boaz, Thank you for this. I am publishing a new series with a minor comment fix included for this patch (formatting to 80-lines properly). I shall keep your ACK-by line in the new patch. Regards, Phil