From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com ([134.134.136.31]:55847 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726204AbeJYKBj (ORCPT ); Thu, 25 Oct 2018 06:01:39 -0400 Date: Thu, 25 Oct 2018 09:31:01 +0800 From: kbuild test robot To: Olga Kornievskaia Cc: kbuild-all@01.org, trond.myklebust@hammerspace.com, anna.schumaker@netapp.com, viro@zeniv.linux.org.uk, smfrench@gmail.com, miklos@szeredi.hu, linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cifs@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-man@vger.kernel.org Subject: [PATCH] fix ptr_ret.cocci warnings Message-ID: <20181025013101.GA41139@lkp-g5> References: <20181024195837.35532-12-olga.kornievskaia@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181024195837.35532-12-olga.kornievskaia@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: From: kbuild test robot fs/nfs/nfs4file.c:345:12-18: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 53b276379386 ("NFS inter ssc open") CC: Olga Kornievskaia Signed-off-by: kbuild test robot --- url: https://github.com/0day-ci/linux/commits/Olga-Kornievskaia/client-side-support-for-inter-SSC-copy/20181025-043859 base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next nfs4file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/nfs/nfs4file.c +++ b/fs/nfs/nfs4file.c @@ -342,7 +342,7 @@ nfs42_ssc_open(struct vfsmount *ss_mnt, res = filep; out: dprintk("<-- %s error %ld filep %p r_ino %p\n", - __func__, IS_ERR(res) ? PTR_ERR(res) : 0, res, r_ino); + __func__, PTR_ERR_OR_ZERO(res), res, r_ino); return res; out_stateowner: