From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f65.google.com ([209.85.128.65]:37132 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728023AbeJYW5e (ORCPT ); Thu, 25 Oct 2018 18:57:34 -0400 Received: by mail-wm1-f65.google.com with SMTP id p2-v6so1716422wmc.2 for ; Thu, 25 Oct 2018 07:24:34 -0700 (PDT) Date: Thu, 25 Oct 2018 15:24:29 +0100 From: Phillip Potter To: Jan Kara Cc: viro@zeniv.linux.org.uk, amir73il@gmail.com, linux-fsdevel@vger.kernel.org Subject: Re: [RFC][PATCH v3 01/10] fs: common implementation of file type Message-ID: <20181025142429.GA11865@pathfinder> References: <20181023201953.GA15687@pathfinder> <20181025112044.GA7711@quack2.suse.cz> <20181025125623.GA8951@pathfinder> <20181025134259.GH3626@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181025134259.GH3626@quack2.suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Oct 25, 2018 at 03:42:59PM +0200, Jan Kara wrote: > On Thu 25-10-18 13:56:23, Phillip Potter wrote: > > Thanks for your comments/feedback, really appreciate it. All good points > > and I will make sure I act on it all before republishing the series. I'd > > be interested to know your thoughts on Ted T'so's suggestion about moving > > the new header to the uapi area - yes or no in your opinion? Happy with > > either, but looking for the widest possible acceptance. Thanks. > > I don't think moving this to uapi headers makes sense. As Amir wrote, all > necessary definitions for userspace already come from glibc headers. > > Honza > -- > Jan Kara > SUSE Labs, CR Thanks, I will leave it in include/linux for now then and separate out the relevant parts to a separate C file as you suggested. Regards, Phil