Re: [RFC][PATCH v3 01/10] fs: common implementation of file type

[Phillip Potter <phil@philpotter.co.uk>]

On Wed, Oct 24, 2018 at 09:16:20AM +0300, Amir Goldstein wrote:
> On Tue, Oct 23, 2018 at 11:19 PM Phillip Potter <phil@philpotter.co.uk> wrote:
> >
> > Many file systems use a copy&paste implementation
> > of dirent to on-disk file type conversions.
> >
> > Create a common implementation to be used by file systems
> > with some useful conversion helpers to reduce open coded
> > file type conversions in file system code.
> >
> > Original patch written by Amir Goldstein.
> 
> Looks good.
> I guess you used 'git apply' or just 'patch'
> What you usually do when applying someone else mostly unchanged
> patches is use 'git am -s -3' so you preserve the original author and
> original commit message including the Signed-of-by line.
> You can edit your patch by hand to change the From: line to change the
> author and add
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> (you sign below me as you changed the patch last)
>

Dear Amir,

I am almost ready to send out the new series with all the suggestions so far
incorporated. Would you be happy for me to add to the commit messages slightly
to mention David Sterba's point about a brief explanation? It would be the same
in each case and I would keep it brief. Also, I have split the functions into a
C file as per Jan Kara's suggestion. Are you still happy for me to still include
your Signed-off-by tag or would you rather I keep it out until you've had a
look? Thanks.

Regards,
Phil