From: Matthew Wilcox <willy@infradead.org>
To: Olga Kornievskaia <olga.kornievskaia@gmail.com>
Cc: trond.myklebust@hammerspace.com, anna.schumaker@netapp.com,
viro@zeniv.linux.org.uk, smfrench@gmail.com, miklos@szeredi.hu,
linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-cifs@vger.kernel.org, linux-unionfs@vger.kernel.org,
linux-man@vger.kernel.org
Subject: Re: [PATCH v4 02/11] VFS: copy_file_range check validity of input source offset
Date: Fri, 26 Oct 2018 14:26:31 -0700 [thread overview]
Message-ID: <20181026212631.GY25444@bombadil.infradead.org> (raw)
In-Reply-To: <20181026201057.36899-4-olga.kornievskaia@gmail.com>
On Fri, Oct 26, 2018 at 04:10:48PM -0400, Olga Kornievskaia wrote:
> +++ b/fs/read_write.c
> @@ -1594,6 +1594,9 @@ ssize_t vfs_copy_file_range(struct file *file_in, loff_t pos_in,
> }
> }
>
> + if (pos_in >= i_size_read(inode_in))
> + return -EINVAL;
> +
> if (file_out->f_op->copy_file_range) {
> ret = file_out->f_op->copy_file_range(file_in, pos_in, file_out,
> pos_out, len, flags);
Is this the right place to check this? Surely we should be checking for
this before calling clone_file_range()?
next prev parent reply other threads:[~2018-10-27 6:05 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 20:10 [PATCH v4 00/11] client-side support for "inter" SSC copy Olga Kornievskaia
2018-10-26 20:10 ` [PATCH v4 01/11] VFS: move cross device copy_file_range() check into filesystems Olga Kornievskaia
2018-10-26 21:23 ` Matthew Wilcox
2018-10-26 22:10 ` Steve French
2018-10-27 9:09 ` Dave Chinner
2018-10-29 14:31 ` Olga Kornievskaia
2018-10-27 11:11 ` Jeff Layton
2018-10-26 20:10 ` [PATCH 1/1] man-page: copy_file_range(2) allow for cross-device copies Olga Kornievskaia
2018-10-27 9:12 ` Dave Chinner
2018-10-27 13:23 ` Matthew Wilcox
2018-10-28 1:33 ` Dave Chinner
2018-10-28 2:39 ` Matthew Wilcox
2018-10-29 14:25 ` Olga Kornievskaia
2018-10-29 15:52 ` Olga Kornievskaia
2018-10-29 17:49 ` Amir Goldstein
2018-10-26 20:10 ` [PATCH v4 02/11] VFS: copy_file_range check validity of input source offset Olga Kornievskaia
2018-10-26 21:26 ` Matthew Wilcox [this message]
2018-10-29 16:09 ` Olga Kornievskaia
2018-10-27 9:27 ` Dave Chinner
2018-10-29 14:41 ` Olga Kornievskaia
2018-10-30 9:03 ` Dave Chinner
2018-10-30 13:40 ` Olga Kornievskaia
2018-10-30 23:40 ` Dave Chinner
2018-10-30 21:10 ` Olga Kornievskaia
2018-10-30 21:12 ` Olga Kornievskaia
2018-10-31 0:14 ` Dave Chinner
2018-10-31 14:51 ` Olga Kornievskaia
2018-10-31 23:33 ` Dave Chinner
2018-10-26 20:10 ` [PATCH v4 03/11] NFS: NFSD defining nl4_servers structure needed by both Olga Kornievskaia
2018-10-27 11:14 ` Jeff Layton
2018-10-29 14:28 ` Olga Kornievskaia
2018-10-26 20:10 ` [PATCH v4 04/11] NFS: add COPY_NOTIFY operation Olga Kornievskaia
2018-10-26 20:10 ` [PATCH v4 05/11] NFS: add ca_source_server<> to COPY Olga Kornievskaia
2018-10-26 20:10 ` [PATCH v4 06/11] NFS: also send OFFLOAD_CANCEL to source server Olga Kornievskaia
2018-10-26 20:10 ` [PATCH v4 07/11] NFS: inter ssc open Olga Kornievskaia
2018-10-26 20:10 ` [PATCH v4 08/11] NFS: skip recovery of copy open on dest server Olga Kornievskaia
2018-10-26 20:10 ` [PATCH v4 09/11] NFS: for "inter" copy treat ESTALE as ENOTSUPP Olga Kornievskaia
2018-10-26 20:10 ` [PATCH v4 10/11] NFS: COPY handle ERR_OFFLOAD_DENIED Olga Kornievskaia
2018-10-26 20:10 ` [PATCH v4 11/11] NFS: replace cross device check in copy_file_range Olga Kornievskaia
2018-10-26 21:22 ` Matthew Wilcox
2018-10-27 11:08 ` Jeff Layton
2018-10-27 13:26 ` Matthew Wilcox
2018-10-29 14:28 ` Olga Kornievskaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181026212631.GY25444@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=anna.schumaker@netapp.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=olga.kornievskaia@gmail.com \
--cc=smfrench@gmail.com \
--cc=trond.myklebust@hammerspace.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).