From: Matthew Wilcox <willy@infradead.org>
To: Olga Kornievskaia <olga.kornievskaia@gmail.com>
Cc: trond.myklebust@hammerspace.com, anna.schumaker@netapp.com,
viro@zeniv.linux.org.uk, smfrench@gmail.com, miklos@szeredi.hu,
linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-cifs@vger.kernel.org, linux-unionfs@vger.kernel.org,
linux-man@vger.kernel.org
Subject: Re: [PATCH v5 12/12] NFS: replace cross device check in copy_file_range
Date: Mon, 29 Oct 2018 10:52:39 -0700 [thread overview]
Message-ID: <20181029175239.GK28520@bombadil.infradead.org> (raw)
In-Reply-To: <20181029175114.GJ28520@bombadil.infradead.org>
On Mon, Oct 29, 2018 at 10:51:14AM -0700, Matthew Wilcox wrote:
> On Mon, Oct 29, 2018 at 01:40:59PM -0400, Olga Kornievskaia wrote:
> > + c_in = (NFS_SERVER(file_inode(file_in)))->nfs_client;
>
> Seems to be an unnecessary pair of brackets there, given existing code:
>
> fs/nfs/delegation.c: struct nfs_client *clp = NFS_SERVER(inode)->nfs_client;
> fs/nfs/dir.c: NFS_SERVER(inode)->dtsize, desc->plus);
> fs/nfs/file.c: if (NFS_SERVER(inode)->flags & NFS_MOUNT_LOCAL_FCNTL)
> (etc)
>
> > + if (c_in->cl_minorversion < 2)
>
> in fact, can't you make this even simpler ...
>
> if (NFS_SERVER(inode)->nfs_client->cl_minorversion < 2)
Oops. Typed too fast:
if (NFS_SERVER(file_inode(file_in)))->nfs_client->cl_minorversion < 2)
> I thought you needed to cast it, but code like this:
>
> fs/nfs/nfs4proc.c: NFS_SERVER(dir)->nfs_client->cl_hostname);
>
> would indicate not.
next prev parent reply other threads:[~2018-10-30 2:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 17:40 [PATCH v5 00/12] client-side support for "inter" SSC copy Olga Kornievskaia
2018-10-29 17:40 ` [PATCH 1/1] NFSv4: cleanup remove unused nfs4_xdev_fs_type Olga Kornievskaia
2018-10-29 17:40 ` [PATCH v5 01/12] VFS: move cross device copy_file_range() check into filesystems Olga Kornievskaia
2018-10-29 18:02 ` Amir Goldstein
2018-10-29 18:33 ` Olga Kornievskaia
2018-10-29 17:40 ` [PATCH v5 02/12] VFS: generic cross-device copy_file_range() support for all filesystems Olga Kornievskaia
2018-10-29 17:46 ` Matthew Wilcox
2018-10-29 18:11 ` Amir Goldstein
2018-10-29 17:40 ` [PATCH v5 03/12] NFS: validity check for source offset in copy_file_range Olga Kornievskaia
2018-10-29 17:40 ` [PATCH v5 04/12] NFS NFSD: defining nl4_servers structure needed by both Olga Kornievskaia
2018-10-29 17:40 ` [PATCH v5 05/12] NFS: add COPY_NOTIFY operation Olga Kornievskaia
2018-10-29 17:40 ` [PATCH v5 06/12] NFS: add ca_source_server<> to COPY Olga Kornievskaia
2018-10-29 17:40 ` [PATCH v5 07/12] NFS: also send OFFLOAD_CANCEL to source server Olga Kornievskaia
2018-10-29 17:40 ` [PATCH v5 08/12] NFS: inter ssc open Olga Kornievskaia
2018-10-29 17:40 ` [PATCH v5 09/12] NFS: skip recovery of copy open on dest server Olga Kornievskaia
2018-10-29 17:40 ` [PATCH v5 10/12] NFS: for "inter" copy treat ESTALE as ENOTSUPP Olga Kornievskaia
2018-10-29 17:40 ` [PATCH v5 11/12] NFS: COPY handle ERR_OFFLOAD_DENIED Olga Kornievskaia
2018-10-29 17:40 ` [PATCH v5 12/12] NFS: replace cross device check in copy_file_range Olga Kornievskaia
2018-10-29 17:46 ` Olga Kornievskaia
2018-10-29 17:51 ` Matthew Wilcox
2018-10-29 17:52 ` Matthew Wilcox [this message]
2018-10-29 17:56 ` Olga Kornievskaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029175239.GK28520@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=anna.schumaker@netapp.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=olga.kornievskaia@gmail.com \
--cc=smfrench@gmail.com \
--cc=trond.myklebust@hammerspace.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).