From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:49724 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729535AbeJ3F2o (ORCPT ); Tue, 30 Oct 2018 01:28:44 -0400 Date: Mon, 29 Oct 2018 13:38:18 -0700 From: Davidlohr Bueso To: Waiman Long Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: Re: [PATCH] fs/proc: introduce /proc/stat2 file Message-ID: <20181029203818.pot26ewxbncfrnua@linux-r8p5> References: <20181029192521.23059-1-dave@stgolabs.net> <0afed890-7c5a-93ee-cdb9-e30775bd9cf1@redhat.com> <20181029200050.iejuxckzbm742dmw@linux-r8p5> <3c5ba85b-5114-c751-0114-ac2cb64c02ea@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <3c5ba85b-5114-c751-0114-ac2cb64c02ea@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, 29 Oct 2018, Waiman Long wrote: >BTW, since you are making stat2 compatible with stat, will that be >easier from the user API perspective if we use a sysctl parameter to >turn on and off IRQs reporting for /proc/stat, for example? For one /proc/stat is also common for debugging envs (ie: performance) and I fear that if a tunnable modifies the behavior of the output, we it might never be usable again (at least not without having users also now consider the systctl parameter). Making it dynamic I think is not worth it. Thanks, Davidlohr