From: Davidlohr Bueso <dave@stgolabs.net>
To: Vito Caputo <vcaputo@pengaru.com>
Cc: Waiman Long <longman@redhat.com>,
akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH] fs/proc: introduce /proc/stat2 file
Date: Tue, 30 Oct 2018 11:57:56 -0700 [thread overview]
Message-ID: <20181030185756.w3f2trelb7nikgmk@linux-r8p5> (raw)
In-Reply-To: <20181029212314.nwruqg6au23ebqlu@shells.gnugeneration.com>
On Mon, 29 Oct 2018, Vito Caputo wrote:
>I'm definitely not in favor of just adding another stat file that is the
>same format as the existing one with the intrs zeroed out. It's a dirty
>hack; fine for your local needs but too gross for upstream IMHO.
I suspect very few users of /proc/stat actually use the irq fields in the
first place. So the common case ends up doing unnecessary operations. The
stat2 approach is not perfect, but I think it's the best approach so far.
This sort of renaming is not uncommon when we cannot break userspace, and
its not like procfs is not already far contaminated already.
There are not enough users that care about this stuff, afaik. What you
suggest sounds like a lot of over-engineering.
Thanks,
Davidlohr
next prev parent reply other threads:[~2018-10-31 3:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 19:25 [PATCH] fs/proc: introduce /proc/stat2 file Davidlohr Bueso
2018-10-29 19:35 ` Waiman Long
2018-10-29 20:00 ` Davidlohr Bueso
2018-10-29 20:29 ` Waiman Long
2018-10-29 20:38 ` Davidlohr Bueso
2018-10-29 20:59 ` Waiman Long
2018-10-29 21:23 ` Vito Caputo
2018-10-29 21:35 ` Waiman Long
2018-10-29 22:41 ` Vito Caputo
2018-10-30 18:57 ` Davidlohr Bueso [this message]
2018-10-30 22:40 ` Vito Caputo
2018-10-30 23:15 ` Davidlohr Bueso
2018-10-29 21:01 ` Waiman Long
2018-10-29 23:04 ` Daniel Colascione
2018-10-30 0:58 ` Vito Caputo
2018-11-06 23:48 ` Andrew Morton
2018-11-07 3:32 ` Davidlohr Bueso
2018-11-07 16:31 ` Waiman Long
2018-11-07 10:03 ` Miklos Szeredi
2018-11-07 15:42 ` Daniel Colascione
2018-11-07 15:54 ` Miklos Szeredi
2018-11-07 16:01 ` Daniel Colascione
2018-11-07 20:32 ` Vito Caputo
2018-11-08 2:07 ` Dave Chinner
2018-11-08 7:24 ` Davidlohr Bueso
2018-11-08 7:44 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030185756.w3f2trelb7nikgmk@linux-r8p5 \
--to=dave@stgolabs.net \
--cc=akpm@linux-foundation.org \
--cc=dbueso@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=vcaputo@pengaru.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).