From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:37066 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727679AbeJaDwq (ORCPT ); Tue, 30 Oct 2018 23:52:46 -0400 Date: Tue, 30 Oct 2018 11:57:56 -0700 From: Davidlohr Bueso To: Vito Caputo Cc: Waiman Long , akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: Re: [PATCH] fs/proc: introduce /proc/stat2 file Message-ID: <20181030185756.w3f2trelb7nikgmk@linux-r8p5> References: <20181029192521.23059-1-dave@stgolabs.net> <0afed890-7c5a-93ee-cdb9-e30775bd9cf1@redhat.com> <20181029200050.iejuxckzbm742dmw@linux-r8p5> <3c5ba85b-5114-c751-0114-ac2cb64c02ea@redhat.com> <20181029203818.pot26ewxbncfrnua@linux-r8p5> <20181029212314.nwruqg6au23ebqlu@shells.gnugeneration.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20181029212314.nwruqg6au23ebqlu@shells.gnugeneration.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, 29 Oct 2018, Vito Caputo wrote: >I'm definitely not in favor of just adding another stat file that is the >same format as the existing one with the intrs zeroed out. It's a dirty >hack; fine for your local needs but too gross for upstream IMHO. I suspect very few users of /proc/stat actually use the irq fields in the first place. So the common case ends up doing unnecessary operations. The stat2 approach is not perfect, but I think it's the best approach so far. This sort of renaming is not uncommon when we cannot break userspace, and its not like procfs is not already far contaminated already. There are not enough users that care about this stuff, afaik. What you suggest sounds like a lot of over-engineering. Thanks, Davidlohr