From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-wm1-f65.google.com ([209.85.128.65]:35246 "EHLO
        mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727716AbeJaSTx (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Wed, 31 Oct 2018 14:19:53 -0400
Received: by mail-wm1-f65.google.com with SMTP id q12-v6so11106920wmq.0
        for <linux-fsdevel@vger.kernel.org>; Wed, 31 Oct 2018 02:22:34 -0700 (PDT)
Date: Wed, 31 Oct 2018 09:22:31 +0000
From: Phillip Potter <phil@philpotter.co.uk>
To: David Sterba <dsterba@suse.cz>
Cc: clm@fb.com, amir73il@gmail.com, viro@zeniv.linux.org.uk,
        jbacik@fb.com, dsterba@suse.com, linux-fsdevel@vger.kernel.org,
        linux-btrfs@vger.kernel.org
Subject: Re: [RFC][PATCH v3 10/10] btrfs: use common file type conversion
Message-ID: <20181031092231.GC19486@pathfinder>
References: <20181027005331.GA9924@pathfinder>
 <20181027005348.GA9996@pathfinder>
 <20181030190317.GH9136@twin.jikos.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181030190317.GH9136@twin.jikos.cz>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Oct 30, 2018 at 08:03:17PM +0100, David Sterba wrote:
> On Sat, Oct 27, 2018 at 01:53:48AM +0100, Phillip Potter wrote:
> > Deduplicate the btrfs file type conversion implementation - file systems
> > that use the same file types as defined by POSIX do not need to define
> > their own versions and can use the common helper functions decared in
> > fs_types.h and implemented in fs_types.c
> > 
> > Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> 
> Acked-by: David Sterba <dsterba@suse.com>

Dear David,

Thanks for this - are you happy for me to move the compile-time tests as per
Amir's suggestion?

Regards,
Phil