linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@stgolabs.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Daniel Colascione <dancol@google.com>,
	longman@redhat.com, linux-fsdevel@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH] fs/proc: introduce /proc/stat2 file
Date: Tue, 6 Nov 2018 19:32:34 -0800	[thread overview]
Message-ID: <20181107033234.djng6kas4tjkevln@linux-r8p5> (raw)
In-Reply-To: <20181106154840.3b448356214afa63dc8cb28c@linux-foundation.org>

On Tue, 06 Nov 2018, Andrew Morton wrote:

>It would be interesting to know precisely which stat fields the
>database-which-shall-not-be-named is looking for.  Then we could cook
>up a very whizzy way of getting at the info.

The ctxt field, afaik. In any case they have been able to work around
the bottleneck. I'm not sure if that is the case for Waiman, however.

>
>A downside of the stat2 approach is that applications will need to be
>rebuilt.  And hopefully when people do this, they'll open
>"/etc/my-app-name/symlink-to-proc-stat" (or use per-application config)
>so they won't need a rebuild when we add /proc/stat3!
>
>A /proc/change-how-stat-works tunable would avoid the need to rebuild
>applications.  But if a system still has some applications which want
>the irq info then that doesn't work.
>
>It's all very sad, really.
>
>btw,
>
>> +The stat2 file acts as a performance alternative to /proc/stat for workloads
>> +and systems that care and are under heavy irq load. In order to to be completely
>> +compatible, /proc/stat and /proc/stat2 are identical with the exception that the
>> +later will show 0 for any (hard)irq-related fields. This refers particularly
>
>"latter"
>
>> +to the "intr" line and 'irq' column for that aggregate in the cpu line.
>
>btw2, please quantify "poor performance".  That helps us determine how
>much we care about all of this!

Up to a quarter of a second is what was reported as being spent every time
/proc/stat is used. This is with 1k cores and 4k interrupts.

Thanks,
Davidlohr

  reply	other threads:[~2018-11-07 13:01 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-29 19:25 [PATCH] fs/proc: introduce /proc/stat2 file Davidlohr Bueso
2018-10-29 19:35 ` Waiman Long
2018-10-29 20:00   ` Davidlohr Bueso
2018-10-29 20:29     ` Waiman Long
2018-10-29 20:38       ` Davidlohr Bueso
2018-10-29 20:59         ` Waiman Long
2018-10-29 21:23           ` Vito Caputo
2018-10-29 21:35             ` Waiman Long
2018-10-29 22:41               ` Vito Caputo
2018-10-30 18:57             ` Davidlohr Bueso
2018-10-30 22:40               ` Vito Caputo
2018-10-30 23:15                 ` Davidlohr Bueso
2018-10-29 21:01 ` Waiman Long
2018-10-29 23:04 ` Daniel Colascione
2018-10-30  0:58   ` Vito Caputo
2018-11-06 23:48   ` Andrew Morton
2018-11-07  3:32     ` Davidlohr Bueso [this message]
2018-11-07 16:31       ` Waiman Long
2018-11-07 10:03     ` Miklos Szeredi
2018-11-07 15:42       ` Daniel Colascione
2018-11-07 15:54         ` Miklos Szeredi
2018-11-07 16:01           ` Daniel Colascione
2018-11-07 20:32       ` Vito Caputo
2018-11-08  2:07       ` Dave Chinner
2018-11-08  7:24         ` Davidlohr Bueso
2018-11-08  7:44           ` Davidlohr Bueso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181107033234.djng6kas4tjkevln@linux-r8p5 \
    --to=dave@stgolabs.net \
    --cc=akpm@linux-foundation.org \
    --cc=dancol@google.com \
    --cc=dbueso@suse.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).