From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f193.google.com ([209.85.214.193]:45265 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726583AbeKHFV3 (ORCPT ); Thu, 8 Nov 2018 00:21:29 -0500 Received: by mail-pl1-f193.google.com with SMTP id o19-v6so8312341pll.12 for ; Wed, 07 Nov 2018 11:49:38 -0800 (PST) Date: Thu, 8 Nov 2018 06:49:07 +1100 From: Matthew Bobrowski To: Jan Kara Cc: Amir Goldstein , linux-api@vger.linux.org, Steve Grubb , linux-fsdevel Subject: Re: [PATCH v6 4/4] fsnotify: don't merge events FS_OPEN_PERM and FS_OPEN_EXEC_PERM Message-ID: <20181107194843.GA2158@development.internal.lab> References: <20e8e7afa5f42e6cf385277159dfd90505232897.1541587830.git.mbobrowski@mbobrowski.org> <20181107141553.GF25758@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181107141553.GF25758@quack2.suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Nov 07, 2018 at 03:15:53PM +0100, Jan Kara wrote: > On Wed 07-11-18 13:30:55, Amir Goldstein wrote: > > On Wed, Nov 7, 2018 at 1:18 PM Matthew Bobrowski > > wrote: > > > > > > Permission events are not to be consolidated into a single event mask. > > > In order for this to not happen, we require additional calls to > > > fsnotify_parent() and fsnotify() within the fsnotify_perm() when the > > > conditon to set FS_OPEN_EXEC_PERM is evaluated to true. > > > > > > > That shouldn't be a separate patch. it should be squashed into the patch > > introducing FS_OPEN_EXEC_PERM there is no reason to have an > > interim commit where events are merged. > > Agreed. > > > > To simplify the code that provides this functionality a simple wrapper > > > fsnotify_path() has been defined to keep things nice and clean. Other > > > functions that used the same fsnotify_parent()/fsnotify() call > > > combination have been updated to use the simplified fsnotify_path() > > > wrapper. > > > > > > > And this should be a separate re-factoring patch. > > And agreed too. You can put this refactoring commit before the one > introducing FS_OPEN_EXEC_PERM to make your life simpler... OK, no problem. > > return should be in newline - just was just me hand writing a patch in email... > > > > After making these small fixes, you may add to patches: > > Reviewed-by: Amir Goldstein Thanks Amir! I will send through v7 shortly. -- Matthew Bobrowski