From: Oleg Nesterov <oleg@redhat.com>
To: Chanho Min <chanho.min@lge.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Christian Brauner <christian@brauner.io>,
Anna-Maria Gleixner <anna-maria@linutronix.de>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
Seungho Park <seungho1.park@lge.com>,
Inkyu Hwang <inkyu.hwang@lge.com>,
Donghwan Jung <donghwan.jung@lge.com>,
Jongsung Kim <neidhard.kim@lge.com>
Subject: Re: [PATCH] exec: make de_thread() freezable
Date: Fri, 9 Nov 2018 10:21:24 +0100 [thread overview]
Message-ID: <20181109092123.GA29945@redhat.com> (raw)
In-Reply-To: <1541752656-12857-1-git-send-email-chanho.min@lge.com>
On 11/09, Chanho Min wrote:
>
> @@ -1083,7 +1084,7 @@ static int de_thread(struct task_struct *tsk)
> while (sig->notify_count) {
> __set_current_state(TASK_KILLABLE);
> spin_unlock_irq(lock);
> - schedule();
> + freezable_schedule();
Thanks, but please note another schedule() in "if (!thread_group_leader(tsk))"
branch, we probably want to change it too?
Oleg.
next prev parent reply other threads:[~2018-11-09 19:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 8:37 [PATCH] exec: make de_thread() freezable Chanho Min
2018-11-09 9:21 ` Oleg Nesterov [this message]
2018-11-12 2:00 ` Chanho Min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109092123.GA29945@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anna-maria@linutronix.de \
--cc=chanho.min@lge.com \
--cc=christian@brauner.io \
--cc=donghwan.jung@lge.com \
--cc=ebiederm@xmission.com \
--cc=inkyu.hwang@lge.com \
--cc=len.brown@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=neidhard.kim@lge.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=seungho1.park@lge.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).