From: Ming Lei <ming.lei@redhat.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@infradead.org>,
Kent Overstreet <kent.overstreet@gmail.com>,
David Sterba <dsterba@suse.cz>, Huang Ying <ying.huang@intel.com>,
Mike Snitzer <snitzer@redhat.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
Theodore Ts'o <tytso@mit.edu>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Coly Li <colyli@suse.de>, Filipe Manana <fdmanana@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH V7 10/24] block: introduce multipage page bvec helpers
Date: Fri, 9 Nov 2018 19:15:09 +0800 [thread overview]
Message-ID: <20181109111508.GA11290@ming.t460p> (raw)
In-Reply-To: <201806272319.0p98i2TZ%fengguang.wu@intel.com>
On Wed, Jun 27, 2018 at 11:59:37PM +0800, kbuild test robot wrote:
> Hi Ming,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on linus/master]
> [also build test WARNING on v4.18-rc2]
> [cannot apply to next-20180627]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Ming-Lei/block-support-multipage-bvec/20180627-214022
> reproduce:
> # apt-get install sparse
> make ARCH=x86_64 allmodconfig
> make C=1 CF=-D__CHECK_ENDIAN__
>
>
> sparse warnings: (new ones prefixed by >>)
>
> net/ceph/messenger.c:842:25: sparse: expression using sizeof(void)
> net/ceph/messenger.c:842:25: sparse: expression using sizeof(void)
> net/ceph/messenger.c:847:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:847:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:847:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:847:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:847:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:847:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:847:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:847:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:847:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:847:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:847:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:847:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:847:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:847:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:848:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:848:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:848:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:848:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:848:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:848:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:848:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:848:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:848:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:848:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:848:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:848:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:848:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:848:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:855:29: sparse: expression using sizeof(void)
> net/ceph/messenger.c:855:29: sparse: expression using sizeof(void)
> net/ceph/messenger.c:855:29: sparse: expression using sizeof(void)
> net/ceph/messenger.c:855:29: sparse: expression using sizeof(void)
> net/ceph/messenger.c:855:29: sparse: expression using sizeof(void)
> net/ceph/messenger.c:855:29: sparse: expression using sizeof(void)
> net/ceph/messenger.c:855:29: sparse: expression using sizeof(void)
> net/ceph/messenger.c:855:29: sparse: expression using sizeof(void)
> net/ceph/messenger.c:855:29: sparse: expression using sizeof(void)
> net/ceph/messenger.c:855:29: sparse: expression using sizeof(void)
> net/ceph/messenger.c:855:29: sparse: expression using sizeof(void)
> net/ceph/messenger.c:855:29: sparse: expression using sizeof(void)
> net/ceph/messenger.c:855:29: sparse: expression using sizeof(void)
> net/ceph/messenger.c:855:29: sparse: expression using sizeof(void)
> net/ceph/messenger.c:869:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:869:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:869:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:869:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:869:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:869:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:869:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:869:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:869:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:869:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:869:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:869:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:869:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:869:9: sparse: expression using sizeof(void)
> include/linux/bvec.h:139:37: sparse: expression using sizeof(void)
> include/linux/bvec.h:139:37: sparse: expression using sizeof(void)
> include/linux/bvec.h:139:37: sparse: expression using sizeof(void)
> include/linux/bvec.h:139:37: sparse: expression using sizeof(void)
> include/linux/bvec.h:139:37: sparse: expression using sizeof(void)
> include/linux/bvec.h:139:37: sparse: expression using sizeof(void)
> include/linux/bvec.h:139:37: sparse: expression using sizeof(void)
> include/linux/bvec.h:139:37: sparse: expression using sizeof(void)
> include/linux/bvec.h:139:37: sparse: expression using sizeof(void)
> include/linux/bvec.h:139:37: sparse: expression using sizeof(void)
> include/linux/bvec.h:139:37: sparse: expression using sizeof(void)
> include/linux/bvec.h:139:37: sparse: expression using sizeof(void)
> include/linux/bvec.h:139:37: sparse: expression using sizeof(void)
> include/linux/bvec.h:139:37: sparse: expression using sizeof(void)
> include/linux/bvec.h:140:32: sparse: expression using sizeof(void)
> include/linux/bvec.h:140:32: sparse: expression using sizeof(void)
> net/ceph/messenger.c:889:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:889:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:889:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:889:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:889:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:889:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:889:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:889:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:889:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:889:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:889:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:889:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:889:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:889:9: sparse: expression using sizeof(void)
> net/ceph/messenger.c:890:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:890:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:890:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:890:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:890:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:890:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:890:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:890:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:890:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:890:47: sparse: expression using sizeof(void)
> net/ceph/messenger.c:890:47: sparse: expression using sizeof(void)
> >> net/ceph/messenger.c:890:47: sparse: too many warnings
>
> vim +890 net/ceph/messenger.c
>
> 6aaa4511 Alex Elder 2013-03-06 862
> 8ae4f4f5 Alex Elder 2013-03-14 863 static bool ceph_msg_data_bio_advance(struct ceph_msg_data_cursor *cursor,
> 8ae4f4f5 Alex Elder 2013-03-14 864 size_t bytes)
> 6aaa4511 Alex Elder 2013-03-06 865 {
> 5359a17d Ilya Dryomov 2018-01-20 866 struct ceph_bio_iter *it = &cursor->bio_iter;
> 6aaa4511 Alex Elder 2013-03-06 867
> 5359a17d Ilya Dryomov 2018-01-20 868 BUG_ON(bytes > cursor->resid);
> 5359a17d Ilya Dryomov 2018-01-20 869 BUG_ON(bytes > bio_iter_len(it->bio, it->iter));
> 25aff7c5 Alex Elder 2013-03-11 870 cursor->resid -= bytes;
> 5359a17d Ilya Dryomov 2018-01-20 871 bio_advance_iter(it->bio, &it->iter, bytes);
> f38a5181 Kent Overstreet 2013-08-07 872
> 5359a17d Ilya Dryomov 2018-01-20 873 if (!cursor->resid) {
> 5359a17d Ilya Dryomov 2018-01-20 874 BUG_ON(!cursor->last_piece);
> 5359a17d Ilya Dryomov 2018-01-20 875 return false; /* no more data */
> 5359a17d Ilya Dryomov 2018-01-20 876 }
> f38a5181 Kent Overstreet 2013-08-07 877
> 5359a17d Ilya Dryomov 2018-01-20 878 if (!bytes || (it->iter.bi_size && it->iter.bi_bvec_done))
> 6aaa4511 Alex Elder 2013-03-06 879 return false; /* more bytes to process in this segment */
> 6aaa4511 Alex Elder 2013-03-06 880
> 5359a17d Ilya Dryomov 2018-01-20 881 if (!it->iter.bi_size) {
> 5359a17d Ilya Dryomov 2018-01-20 882 it->bio = it->bio->bi_next;
> 5359a17d Ilya Dryomov 2018-01-20 883 it->iter = it->bio->bi_iter;
> 5359a17d Ilya Dryomov 2018-01-20 884 if (cursor->resid < it->iter.bi_size)
> 5359a17d Ilya Dryomov 2018-01-20 885 it->iter.bi_size = cursor->resid;
> 25aff7c5 Alex Elder 2013-03-11 886 }
> 6aaa4511 Alex Elder 2013-03-06 887
> 5359a17d Ilya Dryomov 2018-01-20 888 BUG_ON(cursor->last_piece);
> 5359a17d Ilya Dryomov 2018-01-20 889 BUG_ON(cursor->resid < bio_iter_len(it->bio, it->iter));
> 5359a17d Ilya Dryomov 2018-01-20 @890 cursor->last_piece = cursor->resid == bio_iter_len(it->bio, it->iter);
> 6aaa4511 Alex Elder 2013-03-06 891 return true;
> 6aaa4511 Alex Elder 2013-03-06 892 }
> ea96571f Alex Elder 2013-04-05 893 #endif /* CONFIG_BLOCK */
> df6ad1f9 Alex Elder 2012-06-11 894
>
> :::::: The code at line 890 was first introduced by commit
> :::::: 5359a17d2706b86da2af83027343d5eb256f7670 libceph, rbd: new bio handling code (aka don't clone bios)
>
> :::::: TO: Ilya Dryomov <idryomov@gmail.com>
> :::::: CC: Ilya Dryomov <idryomov@gmail.com>
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
Actually this sparse warning on bio_iter_len() can be triggered without this patch
too. This patch changes code in bvec.h, just causes the warned line changed.
thanks,
Ming
next prev parent reply other threads:[~2018-11-09 11:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 12:45 [PATCH V7 00/24] block: support multipage bvec Ming Lei
2018-06-27 12:45 ` [PATCH V7 01/24] dm: use bio_split() when splitting out the already processed bio Ming Lei
2018-06-27 13:17 ` Mike Snitzer
2018-06-27 12:45 ` [PATCH V7 02/24] bcache: don't clone bio in bch_data_verify Ming Lei
2018-06-27 12:45 ` [PATCH V7 03/24] exofs: use bio_clone_fast in _write_mirror Ming Lei
2018-06-27 12:45 ` [PATCH V7 04/24] block: remove bio_clone_kmalloc Ming Lei
2018-06-27 12:45 ` [PATCH V7 05/24] md: remove a bogus comment Ming Lei
2018-06-27 12:45 ` [PATCH V7 06/24] block: unexport bio_clone_bioset Ming Lei
2018-06-27 12:45 ` [PATCH V7 07/24] block: simplify bio_check_pages_dirty Ming Lei
2018-06-27 12:45 ` [PATCH V7 08/24] block: bio_set_pages_dirty can't see NULL bv_page in a valid bio_vec Ming Lei
2018-06-27 12:45 ` [PATCH V7 09/24] block: use bio_add_page in bio_iov_iter_get_pages Ming Lei
2018-06-27 12:45 ` [PATCH V7 10/24] block: introduce multipage page bvec helpers Ming Lei
2018-06-27 15:59 ` kbuild test robot
2018-11-09 11:15 ` Ming Lei [this message]
2018-06-27 12:45 ` [PATCH V7 11/24] block: introduce bio_for_each_bvec() Ming Lei
2018-06-27 12:45 ` [PATCH V7 12/24] block: use bio_for_each_bvec() to compute multipage bvec count Ming Lei
2018-06-27 12:45 ` [PATCH V7 13/24] block: use bio_for_each_bvec() to map sg Ming Lei
2018-06-27 12:45 ` [PATCH V7 14/24] block: introduce bvec_last_segment() Ming Lei
2018-06-27 12:45 ` [PATCH V7 15/24] fs/buffer.c: use bvec iterator to truncate the bio Ming Lei
2018-06-27 12:45 ` [PATCH V7 16/24] btrfs: use bvec_last_segment to get bio's last page Ming Lei
2018-06-27 12:45 ` [PATCH V7 17/24] btrfs: move bio_pages_all() to btrfs Ming Lei
2018-06-27 12:45 ` [PATCH V7 18/24] block: introduce bio_bvecs() Ming Lei
2018-06-27 12:45 ` [PATCH V7 19/24] block: loop: pass multipage bvec to iov_iter Ming Lei
2018-06-27 12:45 ` [PATCH V7 20/24] bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages() Ming Lei
2018-06-27 15:55 ` Coly Li
2018-06-28 1:28 ` Ming Lei
2018-06-28 2:01 ` Coly Li
2018-06-27 12:45 ` [PATCH V7 21/24] block: allow bio_for_each_segment_all() to iterate over multipage bvec Ming Lei
2018-06-27 12:45 ` [PATCH V7 22/24] block: enable multipage bvecs Ming Lei
2018-06-27 12:45 ` [PATCH V7 23/24] block: always define BIO_MAX_PAGES as 256 Ming Lei
2018-06-27 12:45 ` [PATCH V7 24/24] block: document usage of bio iterator helpers Ming Lei
2018-06-27 18:13 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109111508.GA11290@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@fb.com \
--cc=colyli@suse.de \
--cc=darrick.wong@oracle.com \
--cc=dsterba@suse.cz \
--cc=fdmanana@gmail.com \
--cc=hch@infradead.org \
--cc=kbuild-all@01.org \
--cc=kent.overstreet@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=rdunlap@infradead.org \
--cc=snitzer@redhat.com \
--cc=tytso@mit.edu \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).