From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f67.google.com ([209.85.167.67]:34340 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727995AbeKJDpw (ORCPT ); Fri, 9 Nov 2018 22:45:52 -0500 Date: Fri, 9 Nov 2018 21:04:07 +0300 From: Cyrill Gorcunov To: Rafael David Tinoco Cc: adobriyan@gmail.com, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org Subject: Re: [PATCH] proc: fix and merge proc-self-map-file tests Message-ID: <20181109180407.GO13195@uranus.lan> References: <20181108111105.GC13195@uranus.lan> <20181109113036.21512-1-rafael.tinoco@linaro.org> <20181109114123.GK13195@uranus.lan> <1541763936.3280758.1571224480.76F1EF1C@webmail.messagingengine.com> <20181109114850.GL13195@uranus.lan> <1541764873.3286172.1571234624.727F6284@webmail.messagingengine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1541764873.3286172.1571234624.727F6284@webmail.messagingengine.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Nov 09, 2018 at 10:01:13AM -0200, Rafael David Tinoco wrote: > > Alright, I'm fixing membarrier_test before, so.. I guess we have a competition.. =o) Rafael, Alexey, what about simply wrap the test code with x86 and extend later with all archs which support zero address mapping? --- tools/testing/selftests/proc/proc-self-map-files-002.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) Index: linux-ml.git/tools/testing/selftests/proc/proc-self-map-files-002.c =================================================================== --- linux-ml.git.orig/tools/testing/selftests/proc/proc-self-map-files-002.c +++ linux-ml.git/tools/testing/selftests/proc/proc-self-map-files-002.c @@ -23,6 +23,11 @@ #include #include +/* + * Should run on archs which support zero address mapping. + */ +#if defined(__i386) || defined(__x86_64) + static void pass(const char *fmt, unsigned long a, unsigned long b) { char name[64]; @@ -83,3 +88,12 @@ int main(void) return 0; } + +#else + +int main(void) +{ + return 0; +} + +#endif