From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f193.google.com ([209.85.208.193]:47000 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725758AbeKJFVl (ORCPT ); Sat, 10 Nov 2018 00:21:41 -0500 Date: Fri, 9 Nov 2018 22:39:36 +0300 From: Cyrill Gorcunov To: Rafael David Tinoco Cc: adobriyan@gmail.com, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org Subject: Re: [PATCH] proc: fix and merge proc-self-map-file tests Message-ID: <20181109193936.GP13195@uranus.lan> References: <20181108111105.GC13195@uranus.lan> <20181109113036.21512-1-rafael.tinoco@linaro.org> <20181109114123.GK13195@uranus.lan> <1541763936.3280758.1571224480.76F1EF1C@webmail.messagingengine.com> <20181109114850.GL13195@uranus.lan> <1541764873.3286172.1571234624.727F6284@webmail.messagingengine.com> <20181109180407.GO13195@uranus.lan> <1541789329.305173.1571657968.7229F301@webmail.messagingengine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1541789329.305173.1571657968.7229F301@webmail.messagingengine.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Nov 09, 2018 at 04:48:49PM -0200, Rafael David Tinoco wrote: > > let me see if I got this right.. the premise for this test is to have *at least* > 2 vmas, so we can check if the symlink for the mem range, describing the mapped > area, is correct in procfs files, correct ? if yes, then why to have a totally > duplicated test... just to check if mmap(0, ... MAP_FIXED ...) would work ? > > Wouldn't exist a better place to have such test ? like in > tools/testing/selftests/vm/mmap-null.c or something like it ? genuine > curiosity.. thinking i'm missing something about this test... Ah, I happen to miss that they are identical except nil address. Then true, vm/ looks like more suitable place for that. Do you happen to know which exactly archs reserve first page (together with x86)?