From: Matthew Bobrowski <mbobrowski@mbobrowski.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
linux-api@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Steve Grubb <sgrubb@redhat.com>
Subject: Re: [PATCH v7 1/4] fanotify: return only user requested event types in event mask
Date: Wed, 14 Nov 2018 10:54:46 +1100 [thread overview]
Message-ID: <20181113235445.GB3132@lithium.mbobrowski.org> (raw)
In-Reply-To: <CAOQ4uxjyeMceWGWSbkyNUhJVGYNm_z5DYWQkyc=xSKkbB2Hvyw@mail.gmail.com>
On Tue, Nov 13, 2018 at 07:53:07PM +0200, Amir Goldstein wrote:
> > > @@ -131,11 +137,7 @@ static bool fanotify_should_send_event(struct fsnotify_iter_info *iter_info,
> > > !(marks_mask & FS_ISDIR & ~marks_ignored_mask))
> > > return false;
> >
> > Looking into this before merge, this hunk has apparently slipped during
> > some rebase (missing false->0 conversion).
> >
> > > - if (event_mask & FANOTIFY_OUTGOING_EVENTS &
> > > - marks_mask & ~marks_ignored_mask)
> > > - return true;
> > > -
> > > - return false;
> > > + return event_mask & FANOTIFY_OUTGOING_EVENTS & marks_mask;
> >
> > And here we miss & ~marks_ignored_mask, right?
> >
> > I've changed both in the patch I've merged but I'm checking just to be
> > sure...
> >
> FWIW, changes look correct to me.
Yes, that would be right Jan.
--
Matthew Bobrowski
next prev parent reply other threads:[~2018-11-14 9:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 3:04 [PATCH v7 0/4] fanotify: introduce new event mask FAN_OPEN_EXEC and FAN_OPEN_EXEC_PERM Matthew Bobrowski
2018-11-08 3:05 ` [PATCH v7 1/4] fanotify: return only user requested event types in event mask Matthew Bobrowski
2018-11-13 17:38 ` Jan Kara
2018-11-13 17:53 ` Amir Goldstein
2018-11-13 23:54 ` Matthew Bobrowski [this message]
2018-11-14 12:04 ` Jan Kara
2018-11-08 3:07 ` [PATCH v7 2/4] fanotify: introduce new event mask FAN_OPEN_EXEC Matthew Bobrowski
2018-11-08 18:22 ` Andy Lutomirski
2018-11-09 5:41 ` Matthew Bobrowski
2018-11-09 6:04 ` Andy Lutomirski
2018-11-09 7:27 ` Matthew Bobrowski
2018-11-12 16:14 ` Jan Kara
2018-11-12 16:37 ` Andy Lutomirski
2018-11-13 11:45 ` Matthew Bobrowski
2018-11-13 17:35 ` Jan Kara
2018-11-13 23:26 ` Matthew Bobrowski
2018-11-08 3:10 ` [PATCH v7 3/4] fsnotify: refactor fsnotify_parent()/fsnotify() paired calls when event is on path Matthew Bobrowski
2018-11-08 3:12 ` [PATCH v7 4/4] fanotify: introduce new event mask FAN_OPEN_EXEC_PERM Matthew Bobrowski
2018-11-13 17:53 ` [PATCH v7 0/4] fanotify: introduce new event mask FAN_OPEN_EXEC and FAN_OPEN_EXEC_PERM Jan Kara
2018-11-13 18:01 ` Amir Goldstein
2018-11-14 3:43 ` Amir Goldstein
2018-11-14 12:02 ` Jan Kara
2018-11-14 15:54 ` Amir Goldstein
2018-11-19 10:27 ` Matthew Bobrowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181113235445.GB3132@lithium.mbobrowski.org \
--to=mbobrowski@mbobrowski.org \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).