From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-pg1-f196.google.com ([209.85.215.196]:34677 "EHLO
        mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726937AbeKNJzd (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Wed, 14 Nov 2018 04:55:33 -0500
Received: by mail-pg1-f196.google.com with SMTP id 17so6200145pgg.1
        for <linux-fsdevel@vger.kernel.org>; Tue, 13 Nov 2018 15:54:54 -0800 (PST)
Date: Wed, 14 Nov 2018 10:54:46 +1100
From: Matthew Bobrowski <mbobrowski@mbobrowski.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>, linux-api@vger.kernel.org,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        Steve Grubb <sgrubb@redhat.com>
Subject: Re: [PATCH v7 1/4] fanotify: return only user requested event types
 in event mask
Message-ID: <20181113235445.GB3132@lithium.mbobrowski.org>
References: <cover.1541639254.git.mbobrowski@mbobrowski.org>
 <812e19281cfb4de116fcb8baff1fcddcd63ceb4d.1541639254.git.mbobrowski@mbobrowski.org>
 <20181113173811.GB12023@quack2.suse.cz>
 <CAOQ4uxjyeMceWGWSbkyNUhJVGYNm_z5DYWQkyc=xSKkbB2Hvyw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOQ4uxjyeMceWGWSbkyNUhJVGYNm_z5DYWQkyc=xSKkbB2Hvyw@mail.gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Nov 13, 2018 at 07:53:07PM +0200, Amir Goldstein wrote:
> > > @@ -131,11 +137,7 @@ static bool fanotify_should_send_event(struct fsnotify_iter_info *iter_info,
> > >           !(marks_mask & FS_ISDIR & ~marks_ignored_mask))
> > >               return false;
> >
> > Looking into this before merge, this hunk has apparently slipped during
> > some rebase (missing false->0 conversion).
> >
> > > -     if (event_mask & FANOTIFY_OUTGOING_EVENTS &
> > > -         marks_mask & ~marks_ignored_mask)
> > > -             return true;
> > > -
> > > -     return false;
> > > +     return event_mask & FANOTIFY_OUTGOING_EVENTS & marks_mask;
> >
> > And here we miss & ~marks_ignored_mask, right?
> >
> > I've changed both in the patch I've merged but I'm checking just to be
> > sure...
> >
> FWIW, changes look correct to me.

Yes, that would be right Jan. 

-- 
Matthew Bobrowski