* [PATCH] fsnotify/fdinfo: include fdinfo.h for inotify_show_fdinfo()
@ 2018-11-15 0:12 Eric Biggers
2018-11-15 16:35 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Eric Biggers @ 2018-11-15 0:12 UTC (permalink / raw)
To: linux-fsdevel, Jan Kara; +Cc: Amir Goldstein
From: Eric Biggers <ebiggers@google.com>
inotify_show_fdinfo() is defined in fs/notify/fdinfo.c and declared in
fs/notify/fdinfo.h, but the declaration isn't included at the point of
the definition. Include the header to enforce that the definition
matches the declaration.
This addresses a gcc warning when -Wmissing-prototypes is enabled.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
fs/notify/fdinfo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/notify/fdinfo.c b/fs/notify/fdinfo.c
index 348a184bcdda3..1e2bfd26b3521 100644
--- a/fs/notify/fdinfo.c
+++ b/fs/notify/fdinfo.c
@@ -15,6 +15,7 @@
#include <linux/exportfs.h>
#include "inotify/inotify.h"
+#include "fdinfo.h"
#include "fsnotify.h"
#if defined(CONFIG_PROC_FS)
--
2.19.1.930.g4563a0d9d0-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fsnotify/fdinfo: include fdinfo.h for inotify_show_fdinfo()
2018-11-15 0:12 [PATCH] fsnotify/fdinfo: include fdinfo.h for inotify_show_fdinfo() Eric Biggers
@ 2018-11-15 16:35 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2018-11-15 16:35 UTC (permalink / raw)
To: Eric Biggers; +Cc: linux-fsdevel, Jan Kara, Amir Goldstein
On Wed 14-11-18 16:12:14, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> inotify_show_fdinfo() is defined in fs/notify/fdinfo.c and declared in
> fs/notify/fdinfo.h, but the declaration isn't included at the point of
> the definition. Include the header to enforce that the definition
> matches the declaration.
>
> This addresses a gcc warning when -Wmissing-prototypes is enabled.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Good point. Patch applied. Thanks!
Honza
> ---
> fs/notify/fdinfo.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/notify/fdinfo.c b/fs/notify/fdinfo.c
> index 348a184bcdda3..1e2bfd26b3521 100644
> --- a/fs/notify/fdinfo.c
> +++ b/fs/notify/fdinfo.c
> @@ -15,6 +15,7 @@
> #include <linux/exportfs.h>
>
> #include "inotify/inotify.h"
> +#include "fdinfo.h"
> #include "fsnotify.h"
>
> #if defined(CONFIG_PROC_FS)
> --
> 2.19.1.930.g4563a0d9d0-goog
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-16 2:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-15 0:12 [PATCH] fsnotify/fdinfo: include fdinfo.h for inotify_show_fdinfo() Eric Biggers
2018-11-15 16:35 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).