linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: p.jaroszynski@gmail.com
To: Christoph Hellwig <hch@lst.de>, Michal Hocko <mhocko@suse.com>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	Piotr Jaroszynski <pjaroszynski@nvidia.com>
Subject: [PATCH] iomap: get/put the page in iomap_page_create/release()
Date: Wed, 14 Nov 2018 16:30:00 -0800	[thread overview]
Message-ID: <20181115003000.1358007-1-pjaroszynski@nvidia.com> (raw)

From: Piotr Jaroszynski <pjaroszynski@nvidia.com>

migrate_page_move_mapping() expects pages with private data set to have
a page_count elevated by 1. This is what used to happen for xfs through
the buffer_heads code before the switch to iomap in 82cb14175e7d ("xfs:
add support for sub-pagesize writeback without buffer_heads"). Not
having the count elevated causes move_pages() to fail on memory mapped
files coming from xfs.

Make iomap compatible with the migrate_page_move_mapping() assumption
by elevating the page count as part of iomap_page_create() and lowering
it in iomap_page_release().

Fixes: 82cb14175e7d ("xfs: add support for sub-pagesize writeback
                      without buffer_heads")
Signed-off-by: Piotr Jaroszynski <pjaroszynski@nvidia.com>
---
 fs/iomap.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/fs/iomap.c b/fs/iomap.c
index 90c2febc93ac..23977f9f23a2 100644
--- a/fs/iomap.c
+++ b/fs/iomap.c
@@ -117,6 +117,12 @@ iomap_page_create(struct inode *inode, struct page *page)
 	atomic_set(&iop->read_count, 0);
 	atomic_set(&iop->write_count, 0);
 	bitmap_zero(iop->uptodate, PAGE_SIZE / SECTOR_SIZE);
+
+	/*
+	 * At least migrate_page_move_mapping() assumes that pages with private
+	 * data have their count elevated by 1.
+	 */
+	get_page(page);
 	set_page_private(page, (unsigned long)iop);
 	SetPagePrivate(page);
 	return iop;
@@ -133,6 +139,7 @@ iomap_page_release(struct page *page)
 	WARN_ON_ONCE(atomic_read(&iop->write_count));
 	ClearPagePrivate(page);
 	set_page_private(page, 0);
+	put_page(page);
 	kfree(iop);
 }
 
-- 
2.11.0.262.g4b0a5b2.dirty

             reply	other threads:[~2018-11-15  0:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15  0:30 p.jaroszynski [this message]
2018-11-15  9:30 ` [PATCH] iomap: get/put the page in iomap_page_create/release() Christoph Hellwig
2018-11-15 18:44   ` Piotr Jaroszynski
  -- strict thread matches above, loose matches on Subject: below --
2019-01-21 15:17 Christoph Hellwig
2019-01-31 23:28 ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181115003000.1358007-1-pjaroszynski@nvidia.com \
    --to=p.jaroszynski@gmail.com \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=pjaroszynski@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).