From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:50716 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728124AbeKQCBh (ORCPT ); Fri, 16 Nov 2018 21:01:37 -0500 Date: Fri, 16 Nov 2018 16:48:42 +0100 From: Christoph Hellwig To: Carlos Maiolino Cc: linux-fsdevel@vger.kernel.org, sandeen@redhat.com, hch@lst.de, david@fromorbit.com, darrick.wong@oracle.com Subject: Re: [PATCH 06/20] iomap: Update iomap_fiemap to use new fiemap_ctx structure Message-ID: <20181116154842.GD15119@lst.de> References: <20181030131823.29040-1-cmaiolino@redhat.com> <20181030131823.29040-7-cmaiolino@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181030131823.29040-7-cmaiolino@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Oct 30, 2018 at 02:18:09PM +0100, Carlos Maiolino wrote: > iomap_fiemap() isn't directly called by ioctl_fiemap(), so it doesn't > needed to be changed when fiemap_ctx has been added, update it now. That sentence has some grammar issues. How about simply: "Update iomap_fiemap to take a struct fiemap_ctx". > - struct fiemap_extent_info *fieinfo = f_ctx->fc_data; > u64 start = f_ctx->fc_start; > u64 len = f_ctx->fc_len; > struct gfs2_inode *ip = GFS2_I(inode); > @@ -2019,7 +2018,7 @@ static int gfs2_fiemap(struct inode *inode, struct fiemap_ctx *f_ctx) > if (ret) > goto out; > > - ret = iomap_fiemap(inode, fieinfo, start, len, &gfs2_iomap_ops); > + ret = iomap_fiemap(inode, f_ctx, start, len, &gfs2_iomap_ops); I think we should get rid of the start and len argument as well.