From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:23717 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727033AbeKSMVZ (ORCPT ); Mon, 19 Nov 2018 07:21:25 -0500 Date: Mon, 19 Nov 2018 12:59:21 +1100 From: Dave Chinner To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 3/5] aio: add iocb->ki_blk_qc field Message-ID: <20181119015921.GQ6311@dastard> References: <20181117235317.7366-1-axboe@kernel.dk> <20181117235317.7366-4-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181117235317.7366-4-axboe@kernel.dk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, Nov 17, 2018 at 04:53:15PM -0700, Jens Axboe wrote: > Add the field and have the blockdev direct_IO() helpers set it. > This is in preparation for being able to poll for iocb completion. What purpose does this field serve? And why add it to just blockdev direct_IO and not the other direct IO paths, too? Cheers, Dave. -- Dave Chinner david@fromorbit.com