From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:39544 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726687AbeKSSj2 (ORCPT ); Mon, 19 Nov 2018 13:39:28 -0500 Date: Mon, 19 Nov 2018 00:16:35 -0800 From: Christoph Hellwig To: Damien Le Moal Cc: linux-block@vger.kernel.org, Jens Axboe , Adam Manzanares , Alexander Viro , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 3/7] block: Fix get_task_ioprio() default return value Message-ID: <20181119081635.GN9622@infradead.org> References: <20181119035131.11255-1-damien.lemoal@wdc.com> <20181119035131.11255-4-damien.lemoal@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181119035131.11255-4-damien.lemoal@wdc.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Nov 19, 2018 at 12:51:27PM +0900, Damien Le Moal wrote: > As explained in ioprio_get() and ionice man pages, the default I/O > priority class for processes which have not set an I/O priority using > ioprio_set() is IOPRIO_CLASS_BE and not IOPRIO_CLASS_NONE. While this matches the documentation, we've returned the current values for 10 years, and before that plain 0 without any ioprio magic. It might be safer to just fix the documentation.