From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([198.137.202.133]:39606 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726784AbeKSSmL (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Mon, 19 Nov 2018 13:42:11 -0500
Date: Mon, 19 Nov 2018 00:19:18 -0800
From: Christoph Hellwig <hch@infradead.org>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
        Adam Manzanares <adam.manzanares@wdc.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 6/7] block: prevent merging of requests with different
 priorities
Message-ID: <20181119081918.GQ9622@infradead.org>
References: <20181119035131.11255-1-damien.lemoal@wdc.com>
 <20181119035131.11255-7-damien.lemoal@wdc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181119035131.11255-7-damien.lemoal@wdc.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

> +	/*
> +	 * Don't allow merge of different I/O priorities.
> +	 */
> +	if (req->ioprio != next->ioprio)
> +		return NULL;

> +	/*
> +	 * Don't allow merge of different I/O priorities.
> +	 */
> +	if (rq->ioprio != bio_prio(bio))
> +		return false;
> +

These comments just restate what is obvious in the code.  I would
recommend to drop them.