From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv.linux.org.uk ([195.92.253.2]:48412 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726954AbeK2OMW (ORCPT ); Thu, 29 Nov 2018 09:12:22 -0500 Date: Thu, 29 Nov 2018 03:08:30 +0000 From: Al Viro To: Yang Xiao Cc: "linux-fsdevel@vger.kernel.org" Subject: Re: [PATCH] fs: namespace: convert mnt_namespace.count from atomic_t to refcount_t Message-ID: <20181129030830.GH2217@ZenIV.linux.org.uk> References: <20181128143313.GF2217@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Nov 29, 2018 at 01:58:40AM +0000, Yang Xiao wrote: > Hello, see commit 387ad9674b00 ("kernel: convert cgroup_namespace.count > from atomic_t to refcount_t") for detail. That would be refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. AFAICS, that is the text you'd put into the original posting. Verbatim. Which additional information have I failed to notice in the commit you'd mentioned?