From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=qkOv=OI=fromorbit.com=david@kernel.org>
Date: Fri, 30 Nov 2018 09:43:52 +1100
From: Dave Chinner <david@fromorbit.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: sashal@kernel.org, stable <stable@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Dave Chinner <dchinner@redhat.com>,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	"Luis R. Chamberlain" <mcgrof@kernel.org>
Subject: Re: [PATCH AUTOSEL 4.19 52/68] iomap: sub-block dio needs to zeroout
 beyond EOF
Message-ID: <20181129224352.GN19305@dastard>
References: <20181129055559.159228-1-sashal@kernel.org>
 <20181129055559.159228-52-sashal@kernel.org>
 <20181129121922.GL19305@dastard>
 <CAOQ4uxha4-DhcHQwvWbWuh5QXcDKYJ_b7HVGtT23D_gtkqkQ0A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOQ4uxha4-DhcHQwvWbWuh5QXcDKYJ_b7HVGtT23D_gtkqkQ0A@mail.gmail.com>
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, Nov 29, 2018 at 02:36:50PM +0200, Amir Goldstein wrote:
> > Same again - what's the test plan for these cherry-picked data
> > corruption fixes?
> >
> 
> Dave,
> 
> Just to check if we are on the same page, if this was the test plan:
> https://www.spinics.net/lists/linux-xfs/msg20639.html
> 
> Would "no regressions from baseline" have been sufficient to validate
> those specific patches are solid for stable?

No, not in this case, because fsx in fstests only does 100k ops at
most - it's a smoke test. This isn't sufficient to regression test
fixes that, in some cases, took hundreds of millions of fsx ops to
expose.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com